third_party/WebKit/Source/platform/LifecycleNotifier.h - Issue 1390923003: [Oilpan] Fix wrong usage of Vector<WilBeGCMixin*> in LifecycleNotifier

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/LifecycleNotifier.h

Issue 1390923003: [Oilpan] Fix wrong usage of Vector<WilBeGCMixin*> in LifecycleNotifier (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/LifecycleNotifier.h

diff --git a/third_party/WebKit/Source/platform/LifecycleNotifier.h b/third_party/WebKit/Source/platform/LifecycleNotifier.h

index 94a4784da7648b42c7e2439ab89309ef0a44d3f5..b867206079ab44fbdf89c98278cf25c0b179735a 100644

--- a/third_party/WebKit/Source/platform/LifecycleNotifier.h

+++ b/third_party/WebKit/Source/platform/LifecycleNotifier.h

@@ -106,7 +106,7 @@ inline void LifecycleNotifier<T, Observer>::notifyContextDestroyed()

return;

TemporaryChange<IterationType> scope(m_iterating, IteratingOverAll);

- Vector<Observer*> snapshotOfObservers;

+ WillBeHeapVector<RawPtrWillBeMember<Observer>> snapshotOfObservers;

copyToVector(m_observers, snapshotOfObservers);

for (Observer* observer : snapshotOfObservers) {

// FIXME: Oilpan: At the moment, it's possible that the Observer is

« no previous file with comments | « no previous file | no next file » | no next file with comments »