make cdb test using SYSTEMROOT case-insensitive

make cdb test using SYSTEMROOT case-insensitive

R=mark@chromium.org
BUG=crashpad:46
Committed: https://chromium.googlesource.com/crashpad/crashpad/+/4212d3e4ad0c2a9b820fa2cc7711ea6ab777dc0d

[scottmg, 2015-10-09 23:38:36]

Sigh, hopefully the last twiddle.

[Mark Mentovai, 2015-10-09 23:40:51]

LGTM

https://codereview.chromium.org/1390913008/diff/1/snapshot/win/end_to_end_tes...
File snapshot/win/end_to_end_test.py (right):

https://codereview.chromium.org/1390913008/diff/1/snapshot/win/end_to_end_tes...
snapshot/win/end_to_end_test.py:166: out.Check(r'SystemRoot=C:\\Windows', 'some
of environment captured',
Is this the right number of backslashes, too?

[scottmg, 2015-10-09 23:44:37]

(I switched to separate functions as I think we're not supposed to use default
args.)

https://codereview.chromium.org/1390913008/diff/1/snapshot/win/end_to_end_tes...
File snapshot/win/end_to_end_test.py (right):

https://codereview.chromium.org/1390913008/diff/1/snapshot/win/end_to_end_tes...
snapshot/win/end_to_end_test.py:166: out.Check(r'SystemRoot=C:\\Windows', 'some
of environment captured',
On 2015/10/09 23:40:51, Mark Mentovai wrote:
> Is this the right number of backslashes, too?

I believe so. The r'' takes care of not needing any extras in the string
representation, but \ is still a regex special character, so it needs to be \\
to represent a single \.

[scottmg, 2015-10-09 23:46:06]

On 2015/10/09 23:44:37, scottmg wrote:
> (I switched to separate functions as I think we're not supposed to use default
> args.)

Oh, apparently they are OK in
https://google-styleguide.googlecode.com/svn/trunk/pyguide.html?showone=Defau....

I'll land ps#1 instead then.

> 
>
https://codereview.chromium.org/1390913008/diff/1/snapshot/win/end_to_end_tes...
> File snapshot/win/end_to_end_test.py (right):
> 
>
https://codereview.chromium.org/1390913008/diff/1/snapshot/win/end_to_end_tes...
> snapshot/win/end_to_end_test.py:166: out.Check(r'SystemRoot=C:\\Windows',
'some
> of environment captured',
> On 2015/10/09 23:40:51, Mark Mentovai wrote:
> > Is this the right number of backslashes, too?
> 
> I believe so. The r'' takes care of not needing any extras in the string
> representation, but \ is still a regex special character, so it needs to be \\
> to represent a single \.

[scottmg, 2015-10-09 23:49:26]

Patchset #3 (id:40001) has been deleted

[scottmg, 2015-10-09 23:49:33]

Patchset #2 (id:20001) has been deleted

[scottmg, 2015-10-09 23:50:19]

Committed patchset #2 (id:60001) manually as
4212d3e4ad0c2a9b820fa2cc7711ea6ab777dc0d (presubmit successful).

[Mark Mentovai, 2015-10-10 00:58:28]

Oh, right, regex. Duh.

Happy Thanksgiving!