Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2002)

Unified Diff: snapshot/win/end_to_end_test.py

Issue 1390913008: make cdb test using SYSTEMROOT case-insensitive (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: . Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: snapshot/win/end_to_end_test.py
diff --git a/snapshot/win/end_to_end_test.py b/snapshot/win/end_to_end_test.py
index 48c58a7667d3d3588452f8922f385877fa2ab5d8..bbf442eee09bbd9d725575d63f29a0369f56080c 100644
--- a/snapshot/win/end_to_end_test.py
+++ b/snapshot/win/end_to_end_test.py
@@ -127,8 +127,8 @@ class CdbRun(object):
'-c', command + ';q'
])
- def Check(self, pattern, message):
- match_obj = re.search(pattern, self.out)
+ def Check(self, pattern, message, re_flags=0):
+ match_obj = re.search(pattern, self.out, re_flags)
if match_obj:
# Matched. Consume up to end of match.
self.out = self.out[match_obj.end(0):]
@@ -163,7 +163,8 @@ def RunTests(cdb_path, dump_path, pipe_name):
pipe_name_escaped = pipe_name.replace('\\', '\\\\')
out.Check(r'CommandLine: *\'.*crashy_program.exe *' + pipe_name_escaped,
'some PEB data is correct')
- out.Check(r'SystemRoot=C:\\Windows', 'some of environment captured')
+ out.Check(r'SystemRoot=C:\\Windows', 'some of environment captured',
+ re.IGNORECASE)
out = CdbRun(cdb_path, dump_path, '!teb')
out.Check(r'TEB at', 'found the TEB')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698