more housecleaning: remove DartRules and reportMissingType

more housecleaning: remove DartRules and reportMissingType

R=vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/d5799074938b39930db76fc02393d136b0444d07

[Jennifer Messerly, 2015-10-08 22:01:26]

jmesserly@google.com changed reviewers:
+ leafp@google.com, vsm@google.com

[vsm, 2015-10-09 14:56:17]

lgtm

https://codereview.chromium.org/1390903004/diff/1/lib/src/checker/rules.dart
File lib/src/checker/rules.dart (left):

https://codereview.chromium.org/1390903004/diff/1/lib/src/checker/rules.dart#...
lib/src/checker/rules.dart:211: if (reportMissingType != null)
reportMissingType(expr);
We may want to still assert here.  This was useful in catching differences
(e.g., the analyzer not setting the type on SimpleIds used in method invokes).

[Jennifer Messerly, 2015-10-09 18:11:49]

https://codereview.chromium.org/1390903004/diff/1/lib/src/checker/rules.dart
File lib/src/checker/rules.dart (left):

https://codereview.chromium.org/1390903004/diff/1/lib/src/checker/rules.dart#...
lib/src/checker/rules.dart:211: if (reportMissingType != null)
reportMissingType(expr);
On 2015/10/09 14:56:17, vsm wrote:
> We may want to still assert here.  This was useful in catching differences
> (e.g., the analyzer not setting the type on SimpleIds used in method invokes).

Hmmm. It does still happen though, in various language tests (usually ones for
illegal stuff). Shouldn't Analyzer be reporting these already?

I'm just thinking, I don't see how this code will make sense in Analyzer. All of
TypeRules needs to go...

Here's another idea: I can refactor code_checker.dart to use its own
getStaticType helper, which can then issue an error.

[Jennifer Messerly, 2015-10-09 20:06:45]

PTAL. Redid this based on feedback.

[vsm, 2015-10-09 20:11:29]

lgtm

Yeah, I think missing types would correspond to existing analyzer errors, but
not positive.

In real app code, I don't think I hit this - just the SimpleIdentifier case for
method calls until we fixed that.

[Jennifer Messerly, 2015-10-09 20:12:41]

Committed patchset #2 (id:20001) manually as
d5799074938b39930db76fc02393d136b0444d07 (presubmit successful).