more housecleaning: remove DartRules and reportMissingType

lib/src/checker/rules.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.src.checker.rules;
 
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/resolver.dart';
 
 import '../../strong_mode.dart' show StrongModeOptions;
 import '../info.dart';
 import '../utils.dart' as utils;
 
 abstract class TypeRules {
   final TypeProvider provider;
 
   /// Map of fields / properties / methods on Object.
   final Map<String, DartType> objectMembers;
 
   TypeRules(TypeProvider provider)
       : provider = provider,
         objectMembers = utils.getObjectMemberMap(provider);
 
-  MissingTypeReporter reportMissingType;
-
   bool isSubTypeOf(DartType t1, DartType t2);
   bool isAssignable(DartType t1, DartType t2);
 
   bool isGroundType(DartType t) => true;
   // TODO(vsm): The default implementation is not ignoring the return type,
   // only the restricted override is.
   bool isFunctionSubTypeOf(FunctionType f1, FunctionType f2,
           {bool fuzzyArrows: true, bool ignoreReturn: false}) =>
       isSubTypeOf(f1, f2);
 
@@ skipping 96 matching lines @@
       return type;
     } else if (type is InterfaceType && type.element == expectedType.element) {
       return type.typeArguments[0];
     } else {
       // Malformed type - fallback on analyzer error.
       return null;
     }
   }
 }
 
-// TODO(jmesserly): this is unused.
-class DartRules extends TypeRules {
-  DartRules(TypeProvider provider) : super(provider);
-
-  MissingTypeReporter reportMissingType = null;
-
-  bool isSubTypeOf(DartType t1, DartType t2) {
-    return t1.isSubtypeOf(t2);
-  }
-
-  bool isAssignable(DartType t1, DartType t2) {
-    return t1.isAssignableTo(t2);
-  }
-
-  StaticInfo checkAssignment(Expression expr, DartType toType) {
-    final fromType = getStaticType(expr);
-    if (!isAssignable(fromType, toType)) {
-      return new StaticTypeError(this, expr, toType);
-    }
-    return null;
-  }
-
-  DartType elementType(Element e) {
-    return (e as dynamic).type;
-  }
-
-  /// By default, all invocations are dynamic in Dart.
-  bool isDynamic(DartType t) => true;
-  bool isDynamicTarget(Expression expr) => true;
-  bool isDynamicCall(Expression call) => true;
-}
-
-typedef void MissingTypeReporter(Expression expr);
-
 class RestrictedRules extends TypeRules {
-  MissingTypeReporter reportMissingType = null;
   final StrongModeOptions options;
   final List<DartType> _nonnullableTypes;
   DownwardsInference inferrer;
 
   DartType _typeFromName(String name) {
     switch (name) {
       case 'int':
         return provider.intType;
       case 'double':
         return provider.doubleType;
@@ skipping 10 matching lines @@
 
   RestrictedRules(TypeProvider provider, {this.options})
       : _nonnullableTypes = <DartType>[],
         super(provider) {
     var types = options.nonnullableTypes;
     _nonnullableTypes.addAll(types.map(_typeFromName));
     inferrer = new DownwardsInference(this);
   }
 
   DartType getStaticType(Expression expr) {
-    var type = expr.staticType;
-    if (type != null) return type;
-    if (reportMissingType != null) reportMissingType(expr);
-    return provider.dynamicType;
+    return expr.staticType ?? provider.dynamicType;
   }
 
   bool _isBottom(DartType t, {bool dynamicIsBottom: false}) {
     if (t.isDynamic && dynamicIsBottom) return true;
     // TODO(vsm): We need direct support for non-nullability in DartType.
     // This should check on "true/nonnullable" Bottom
     if (t.isBottom && _nonnullableTypes.isEmpty) return true;
     return false;
   }
 
@@ skipping 624 matching lines @@
     var entries = e.entries;
     bool inferEntry(MapLiteralEntry entry) {
       return _inferExpression(entry.key, kType, errors) &&
           _inferExpression(entry.value, vType, errors);
     }
     var b = entries.every(inferEntry);
     if (b) annotateMapLiteral(e, targs);
     return b;
   }
 }