Issue 1390883004: Merge to XFA: Stop inlining CJBig2_BitStream.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1390883004: Merge to XFA: Stop inlining CJBig2_BitStream. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Stop inlining CJBig2_BitStream. TBR=tsepez@chromium.org Review URL: https://codereview.chromium.org/1393823002 . (cherry picked from commit a0f2b67bd659e3f1780edfac56d8754bca685d5f) Committed: https://pdfium.googlesource.com/pdfium/+/4e5686796b7274f8155eb3a5d9a6d8a3779bcd6f

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+206 lines, -258 lines)			Patch
M	BUILD.gn	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_BitStream.h	View	1 chunk	+22 lines, -258 lines	0 comments	Download
A	core/src/fxcodec/jbig2/JBig2_BitStream.cpp	View	1 chunk	+178 lines, -0 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_HuffmanTable.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pdfium.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 2 months ago (2015-10-08 04:33:59 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4e5686796b7274f8155eb3a5d9a6d8a3779bcd6f (presubmit successful).