Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 1393823002: Stop inlining CJBig2_BitStream. (Closed)

Created:
5 years, 2 months ago by Lei Zhang
Modified:
5 years, 2 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : simplify #

Patch Set 3 : delete dead code #

Patch Set 4 : simplify #

Patch Set 5 : more #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -258 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_BitStream.h View 1 2 3 4 1 chunk +22 lines, -258 lines 0 comments Download
A core/src/fxcodec/jbig2/JBig2_BitStream.cpp View 1 2 3 4 1 chunk +178 lines, -0 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanDecoder.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M core/src/fxcodec/jbig2/JBig2_HuffmanTable.cpp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lei Zhang
5 years, 2 months ago (2015-10-07 08:57:58 UTC) #2
Tom Sepez
LGTM, though I didn't verify that you pasted the code into .cpp file accurately.
5 years, 2 months ago (2015-10-07 16:52:08 UTC) #3
Lei Zhang
On 2015/10/07 16:52:08, Tom Sepez wrote: > LGTM, though I didn't verify that you pasted ...
5 years, 2 months ago (2015-10-07 17:41:16 UTC) #4
Tom Sepez
On 2015/10/07 17:41:16, Lei Zhang wrote: > On 2015/10/07 16:52:08, Tom Sepez wrote: > > ...
5 years, 2 months ago (2015-10-07 17:43:44 UTC) #5
Lei Zhang
5 years, 2 months ago (2015-10-07 18:12:10 UTC) #6
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
a0f2b67bd659e3f1780edfac56d8754bca685d5f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698