Issue 1390623003: Merge to XFA: Remove pointless CPDFSDK_PageView usage in CJS_Object / CJS_EmbedObj.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1390623003: Merge to XFA: Remove pointless CPDFSDK_PageView usage in CJS_Object / CJS_EmbedObj. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Remove pointless CPDFSDK_PageView usage in CJS_Object / CJS_EmbedObj. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1374723004 . (cherry picked from commit 4942ed7a79188bd832c2a599e7dd94ea59b674ae) Committed: https://pdfium.googlesource.com/pdfium/+/d607f5b9fc4c89ea480d882de6df80e6a6338b0b

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -34 lines)			Patch
M	fpdfsdk/include/javascript/JS_Object.h	View		3 chunks	+6 lines, -11 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Object.cpp	View	1	4 chunks	+6 lines, -21 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 2 months ago (2015-10-06 00:06:12 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
d607f5b9fc4c89ea480d882de6df80e6a6338b0b (presubmit successful).