Issue 1374723004: Remove pointless CPDFSDK_PageView usage in CJS_Object / CJS_EmbedObj.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1374723004: Remove pointless CPDFSDK_PageView usage in CJS_Object / CJS_EmbedObj. (Closed)

Created:
5 years, 2 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -35 lines)			Patch
M	fpdfsdk/include/javascript/JS_Object.h	View	3 chunks	+6 lines, -11 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Object.cpp	View	4 chunks	+7 lines, -22 lines	0 comments	Download
M	fpdfsdk/src/javascript/app.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Lei Zhang

5 years, 2 months ago (2015-10-05 03:41:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4942ed7a79188bd832c2a599e7dd94ea59b674ae (presubmit successful).