Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1390463002: Rollback https://codereview.chromium.org/1380223003 (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -164 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 2 chunks +45 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 2 chunks +1 line, -8 lines 0 comments Download
D pkg/analysis_server/lib/src/utilities/documentation.dart View 1 chunk +0 lines, -69 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 5 chunks +7 lines, -27 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart View 1 chunk +0 lines, -40 lines 0 comments Download
M pkg/analysis_server/test/services/completion/prefixed_element_contributor_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-05 00:05:42 UTC) #1
scheglov
Committed patchset #1 (id:1) manually as e6053aa1352798681d591ba803c61e289ed34534 (presubmit successful).
5 years, 2 months ago (2015-10-05 00:07:15 UTC) #2
Brian Wilkerson
5 years, 2 months ago (2015-10-05 14:03:48 UTC) #3
Message was sent while issue was closed.
LGTM, although I think we need to address the underlying problem and consider
re-applying the original change afterward.

Powered by Google App Engine
This is Rietveld 408576698