Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1380223003: Issue 23694. Include 'docSummary' and 'docComplete' into CompletionSuggestion. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -53 lines) Patch
M pkg/analysis_server/lib/src/computer/computer_hover.dart View 2 chunks +2 lines, -45 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 2 chunks +8 lines, -1 line 0 comments Download
A pkg/analysis_server/lib/src/utilities/documentation.dart View 1 chunk +69 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 1 5 chunks +27 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/services/completion/imported_reference_contributor_test.dart View 1 chunk +40 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/prefixed_element_contributor_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
scheglov
5 years, 2 months ago (2015-10-01 21:57:12 UTC) #1
Brian Wilkerson
LGTM. Do we know what kind of impact this has on the performance of code ...
5 years, 2 months ago (2015-10-01 22:04:34 UTC) #3
scheglov
On 2015/10/01 22:04:34, Brian Wilkerson wrote: > LGTM. Do we know what kind of impact ...
5 years, 2 months ago (2015-10-01 22:24:29 UTC) #4
Brian Wilkerson
> I'm not sure that we want to take such performance hit. I agree. Let's ...
5 years, 2 months ago (2015-10-01 23:48:43 UTC) #5
scheglov
5 years, 2 months ago (2015-10-04 23:16:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1af7b154af904cf0627708818eb15e9fb5066f8a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698