cloud_print/service/win/setup_listener.cc - Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/setup_listener.cc

Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/service/win/setup_listener.cc

diff --git a/cloud_print/service/win/setup_listener.cc b/cloud_print/service/win/setup_listener.cc

index 67cb85b8797dc98826abc12305cffac1b086db9f..c4ffc79d9908d26cdc6b6d97cece71688c67235a 100644

--- a/cloud_print/service/win/setup_listener.cc

+++ b/cloud_print/service/win/setup_listener.cc

@@ -119,7 +119,8 @@ void SetupListener::Connect(const base::string16& user) {

if (pipe.IsValid()) {

channel_ = IPC::Channel::CreateServer(IPC::ChannelHandle(pipe.Get()),

this);

- channel_->Connect();

+ if (!channel_->Connect())

+ done_event_->Signal();

}

« no previous file with comments | « cloud_print/service/win/service_listener.cc ('k') | components/storage_monitor.gypi » ('j') | no next file with comments »