cloud_print/service/win/service_listener.cc - Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cloud_print/service/win/service_listener.cc

Issue 1390223002: Enforce WARN_UNUSED_RESULT attribute on Windows (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cloud_print/service/win/service_listener.cc

diff --git a/cloud_print/service/win/service_listener.cc b/cloud_print/service/win/service_listener.cc

index 52d8ab8785d7c02a39e7e389fb848ca736fcf1f2..31173c791b8c028c55ea009a3625d1d32e9dc9bc 100644

--- a/cloud_print/service/win/service_listener.cc

+++ b/cloud_print/service/win/service_listener.cc

@@ -96,7 +96,8 @@ void ServiceListener::Connect() {

// need for an attachment broker.

channel_ =

IPC::Channel::CreateClient(IPC::ChannelHandle(handle.Get()), this);

- channel_->Connect();

+ bool connected = channel_->Connect();

+ DCHECK(connected);

} else {

ipc_thread_->message_loop()->PostDelayedTask(

FROM_HERE,