Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(837)

Issue 139013006: Revert 245031 "This CL" (Closed)

Created:
6 years, 11 months ago by dxie
Modified:
6 years, 11 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, sadrul, nkostylev+watch_chromium.org, Ian Vollick, tfarina, ben+corewm_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 245031 "This CL" > This CL > - Introduces views::corewm::SetWindowShowAnimationDuration() and views::corewm::SetWindowHideAnimationDuration(). This allows the animation duration for showing and hiding the window to be different. > - Fixes a memory leak in AddLayerAnimationsForRotate() > - Fixes calls to views::corewm::SetWindowVisibilityAnimationType() and views::corewm::SetWindowVisibilityAnimationDuration(). In particular, the animation type and animation duration were not properly reset. So docking a window would permanently affect the duration of the show and hide animations. > - Removes unneeded ScopedLayerAnimationSettings::LockTransitionDuration(). This API is not currently necessary so it is best for it to not exist at this point in time. > > BUG=323791 > TEST=None > R=varkha, oshima > TBR=vollick > > Review URL: https://codereview.chromium.org/105673008 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245870

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -118 lines) Patch
M ash/system/tray/tray_background_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/dock/docked_window_layout_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 6 chunks +22 lines, -20 lines 0 comments Download
M ash/wm/window_animations.cc View 5 chunks +11 lines, -15 lines 0 comments Download
M ash/wm/window_animations_unittest.cc View 2 chunks +103 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/layer_animator.h View 3 chunks +9 lines, -5 lines 0 comments Download
M ui/compositor/layer_animator.cc View 3 chunks +9 lines, -2 lines 0 comments Download
M ui/compositor/scoped_layer_animation_settings.h View 2 chunks +7 lines, -0 lines 0 comments Download
M ui/compositor/scoped_layer_animation_settings.cc View 3 chunks +11 lines, -3 lines 0 comments Download
M ui/views/corewm/window_animations.h View 1 chunk +1 line, -19 lines 0 comments Download
M ui/views/corewm/window_animations.cc View 7 chunks +23 lines, -52 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dxie
6 years, 11 months ago (2014-01-20 08:13:02 UTC) #1
dxie
6 years, 11 months ago (2014-01-20 08:13:28 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r245870 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698