Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: chrome/browser/download/save_page_uitest.cc

Issue 139006: Disable some UI tests on Linux due to crash flakiness:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_uitest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/save_page_uitest.cc
===================================================================
--- chrome/browser/download/save_page_uitest.cc (revision 18837)
+++ chrome/browser/download/save_page_uitest.cc (working copy)
@@ -15,6 +15,14 @@
#include "chrome/test/ui/ui_test.h"
#include "net/url_request/url_request_unittest.h"
+#if defined(OS_LINUX)
+#define MAYBE_SaveCompleteHTML DISABLED_SaveCompleteHTML
+#define MAYBE_SaveHTMLOnly DISABLED_SaveHTMLOnly
+#else
+#define MAYBE_SaveCompleteHTML SaveCompleteHTML
+#define MAYBE_SaveHTMLOnly SaveHTMLOnly
+#endif
+
const char* const kTestDir = "save_page";
const char* const kAppendedExtension = ".htm";
@@ -78,7 +86,8 @@
FilePath download_dir_;
};
-TEST_F(SavePageTest, SaveHTMLOnly) {
+// Flaky on Linux: http://code.google.com/p/chromium/issues/detail?id=14746
+TEST_F(SavePageTest, MAYBE_SaveHTMLOnly) {
std::string file_name("a.htm");
FilePath full_file_name = save_dir_.AppendASCII(file_name);
FilePath dir = save_dir_.AppendASCII("a_files");
@@ -99,7 +108,8 @@
EXPECT_FALSE(file_util::PathExists(dir));
}
-TEST_F(SavePageTest, SaveCompleteHTML) {
+// Flaky on Linux: http://code.google.com/p/chromium/issues/detail?id=14746
+TEST_F(SavePageTest, MAYBE_SaveCompleteHTML) {
std::string file_name = "b.htm";
FilePath full_file_name = save_dir_.AppendASCII(file_name);
FilePath dir = save_dir_.AppendASCII("b_files");
« no previous file with comments | « chrome/browser/download/download_uitest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698