Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2227)

Unified Diff: chrome/browser/download/download_uitest.cc

Issue 139006: Disable some UI tests on Linux due to crash flakiness:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/download/save_page_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_uitest.cc
===================================================================
--- chrome/browser/download/download_uitest.cc (revision 18837)
+++ chrome/browser/download/download_uitest.cc (working copy)
@@ -27,6 +27,14 @@
#include "net/base/net_util.h"
#include "net/url_request/url_request_unittest.h"
+#if defined(OS_LINUX)
+#define MAYBE_UnknownSize DISABLED_UnknownSize
+#define MAYBE_IncognitoDownload DISABLED_IncognitoDownload
+#else
+#define MAYBE_UnknownSize UnknownSize
+#define MAYBE_IncognitoDownload IncognitoDownload
+#endif
+
namespace {
const wchar_t kDocRoot[] = L"chrome/test/data";
@@ -270,7 +278,8 @@
// The test will first attempt to download a file; but the server will "pause"
// in the middle until the server receives a second request for
// "download-finish. At that time, the download will finish.
-TEST_F(DownloadTest, UnknownSize) {
+// Flaky on Linux: http://code.google.com/p/chromium/issues/detail?id=14746
+TEST_F(DownloadTest, MAYBE_UnknownSize) {
GURL url(URLRequestSlowDownloadJob::kUnknownSizeUrl);
FilePath filename;
net::FileURLToFilePath(url, &filename);
@@ -291,7 +300,7 @@
// Test that when downloading an item in Incognito mode, we don't crash when
// closing the last Incognito window (http://crbug.com/13983).
-TEST_F(DownloadTest, IncognitoDownload) {
+TEST_F(DownloadTest, MAYBE_IncognitoDownload) {
// Open a regular window and sanity check default values for window / tab
// count and shelf visibility.
scoped_refptr<BrowserProxy> browser(automation()->GetBrowserWindow(0));
« no previous file with comments | « no previous file | chrome/browser/download/save_page_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698