Issue 1389943002: Allow SkIcoCodec to fail due to conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1389943002: Allow SkIcoCodec to fail due to conversion (Closed)

Created:
5 years, 2 months ago by scroggo

Modified:
5 years, 2 months ago

Reviewers:
msarett

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Allow SkIcoCodec to fail due to conversion Even if the client chooses dimensions that were suggested by SkIcoCodec, it is possible for the color conversion to be incorrect, so it can still reach the exit case of kInvalidConversion. For example, when running nanobench, we attempt to decode the image to Alpha_8, which the codec does not support. This allows running nanobench in debug mode without asserting. BUG=skia:3418 Committed: https://skia.googlesource.com/skia/+/85f0d5d6e6a8ae2d5bdfb784fdf426a89dad2c0e

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	src/codec/SkCodec_libico.cpp	View		1 chunk	+0 lines, -3 lines	0 comments	Download

Dependent Patchsets:

Issue 1387183003 Patch 1

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389943002/1

5 years, 2 months ago (2015-10-06 17:41:09 UTC) #5

commit-bot: I haz the power

5 years, 2 months ago (2015-10-06 17:47:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/85f0d5d6e6a8ae2d5bdfb784fdf426a89dad2c0e

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages