Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 1387183003: Remove superfluous error messages from nanobench (Closed)

Created:
5 years, 2 months ago by scroggo
Modified:
5 years, 2 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@icoFormat
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove superfluous error messages from nanobench When running nanobench --images, I see lots of "errors" from cases that are simply not supported. Silence these. BUG=skia:3418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M tools/SkBitmapRegionCanvas.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M tools/SkBitmapRegionDecoderInterface.cpp View 3 chunks +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (1 generated)
scroggo
5 years, 2 months ago (2015-10-06 17:18:10 UTC) #2
msarett
Can we change these all to SkCodecPrintf instead? I have done that in a CL ...
5 years, 2 months ago (2015-10-06 17:31:46 UTC) #3
scroggo
On 2015/10/06 17:31:46, msarett wrote: > Can we change these all to SkCodecPrintf instead? I ...
5 years, 2 months ago (2015-10-06 17:42:07 UTC) #4
msarett
Linking the CL. https://codereview.chromium.org/1321433002/ I wouldn't describe this as "close to landing", so if this ...
5 years, 2 months ago (2015-10-06 17:45:44 UTC) #5
msarett
Can we close this now that https://codereview.chromium.org/1395383002/ has landed?
5 years, 2 months ago (2015-10-13 20:25:07 UTC) #6
scroggo
5 years, 2 months ago (2015-10-13 20:25:42 UTC) #7
Message was sent while issue was closed.
On 2015/10/13 20:25:07, msarett wrote:
> Can we close this now that https://codereview.chromium.org/1395383002/ has
> landed?

Yes. Closed

Powered by Google App Engine
This is Rietveld 408576698