Allow suppressing message extraction warnings, providing a prefix for generated files, and format w…

pkg/intl/test/message_extraction/extract_to_json.dart

Index: pkg/intl/test/message_extraction/extract_to_json.dart
diff --git a/pkg/intl/test/message_extraction/extract_to_json.dart b/pkg/intl/test/message_extraction/extract_to_json.dart
index 7d719ee246196accead88ab2428ad211ccc15ec9..05230a621b3984e83f821715a1d8c7ad9e1de42a 100644
--- a/pkg/intl/test/message_extraction/extract_to_json.dart
+++ b/pkg/intl/test/message_extraction/extract_to_json.dart
@@ -26,9 +26,17 @@ import 'dart:json' as json;
 import 'package:pathos/path.dart' as path;
 import 'package:intl/src/intl_message.dart';
 import 'find_output_directory.dart';
+import 'package:args/args.dart';
 
 main() {
   var args = new Options().arguments;
+  var targetDir = findOutputDirectory(args);

[Siggi Cherem (dart-lang), 2013/04/23 02:12:51]

why parse it both here and with the output-dir option below?

[Alan Knight, 2013/04/23 17:59:56]

Removed. See next point.

+  var parser = new ArgParser();
+  parser.addFlag("suppress-warnings", defaultsTo: false,
+      callback: (x) => suppressWarnings = x);
+  void setTargetDir(value) { if (value != null) targetDir = value;};

[Siggi Cherem (dart-lang), 2013/04/23 02:12:51]

is it possible for it to be null? (given that you provided a default value?

[Alan Knight, 2013/04/23 17:59:56]

Changed it so that we don't have a default value for the argument and call
findOutputDirectory here if no value is provided. 

[Siggi Cherem (dart-lang), 2013/04/23 18:56:37]

I guess part of my point is, if you are now using the ArgsParser, there is no
need to use 'fundOutputDirectory'. IIUC that function was doing a subset of the
parsing that argParser does already. Might be enough to replace the default
value with '.'.

[Alan Knight, 2013/04/23 21:37:19]

Doh! I'd forgotten that was what that was doing. Deleted findOutputDirectory and
its uses.

+  parser.addOption("output-dir", defaultsTo: targetDir, callback: setTargetDir);
+  parser.parse(args);
   if (args.length == 0) {
     print('Usage: extract_to_json [--output-dir=<dir>] [files.dart]');
     print('Accepts Dart files and produces intl_messages.json');
@@ -39,7 +47,6 @@ main() {
     var messages = parseFile(new File(arg));
     messages.forEach((k, v) => allMessages.add(toJson(v)));
   }
-  var targetDir = findOutputDirectory(args);
   var file = new File(path.join(targetDir, 'intl_messages.json'));
   file.writeAsStringSync(json.stringify(allMessages));
 }