Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Unified Diff: pkg/intl/test/message_extraction/generate_from_json.dart

Issue 13898014: Allow suppressing message extraction warnings, providing a prefix for generated files, and format w… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/intl/test/message_extraction/generate_from_json.dart
diff --git a/pkg/intl/test/message_extraction/generate_from_json.dart b/pkg/intl/test/message_extraction/generate_from_json.dart
index 7bbb878d241448d5be2743f37cb360e188fd96f8..32c0abe4db89b025566d16530d73630ba677fd9a 100644
--- a/pkg/intl/test/message_extraction/generate_from_json.dart
+++ b/pkg/intl/test/message_extraction/generate_from_json.dart
@@ -22,6 +22,7 @@ import 'extract_to_json.dart';
import 'package:intl/generate_localized.dart';
import 'dart:json' as json;
import 'package:pathos/path.dart' as path;
+import 'package:args/args.dart';
import 'find_output_directory.dart';
/**
@@ -31,19 +32,29 @@ import 'find_output_directory.dart';
Map<String, IntlMessage> messages;
main() {
+ var targetDir;
var args = new Options().arguments;
+ var parser = new ArgParser();
+ parser.addFlag("suppress-warnings", defaultsTo: false,
+ callback: (x) => suppressWarnings = x);
+ parser.addOption("output-dir", defaultsTo: '.',
+ callback: (x) => targetDir = x);
+ parser.addOption("generated-file-prefix", defaultsTo: '',
+ callback: (x) => generatedFilePrefix = x);
+ parser.parse(args);
if (args.length == 0) {
- print('Usage: generate_from_json [--output-dir=<dir>] [originalFiles.dart]'
- ' [translationFiles.json]');
+ print('Usage: generate_from_json [--output-dir=<dir>]'
+ ' [generated-file-prefix=<prefix>] file1.dart file2.dart ...'
+ ' outputFile.json');
exit(0);
}
- var targetDir = findOutputDirectory(args);
- var isDart = new RegExp(r'\.dart');
- var isJson = new RegExp(r'\.json');
- var dartFiles = args.where(isDart.hasMatch).toList();
- var jsonFiles = args.where(isJson.hasMatch).toList();
+ var dartFiles = args.where((x) => x.endsWith("dart")).toList();
+ var jsonFiles = args.where((x) => x.endsWith(".json")).toList();
+ // We're re-parsing the original files to find the corresponding messages,
+ // so if there are warnings extracting the messages, suppress them.
+ suppressWarnings = true;
var allMessages = dartFiles.map((each) => parseFile(new File(each)));
messages = new Map();
@@ -51,11 +62,12 @@ main() {
eachMap.forEach((key, value) => messages[key] = value);
}
for (var arg in jsonFiles) {
- var file = new File(path.join(targetDir, arg));
- var translations = generateLocaleFile(file, targetDir);
+ var file = new File(arg);
+ generateLocaleFile(file, targetDir);
}
- var mainImportFile = new File(path.join(targetDir, 'messages_all.dart'));
+ var mainImportFile = new File(path.join(targetDir,
+ '${generatedFilePrefix}messages_all.dart'));
mainImportFile.writeAsStringSync(generateMainImportFile());
}

Powered by Google App Engine
This is Rietveld 408576698