Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1389783002: Make the vast majority of JS headers private to src/javascript. (Closed)

Created:
5 years, 2 months ago by Tom Sepez
Modified:
5 years, 2 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the vast majority of JS headers private to src/javascript. The fpdfsdk/include/javascript/IJavascript.h is the sole API. This required moving a creaton method to it from JS_Runtime. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/5b3d0208723f21c50b9922bdc500c9d78c359a25

Patch Set 1 #

Patch Set 2 : stray file. #

Total comments: 31

Patch Set 3 : Rebase. #

Patch Set 4 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -3666 lines) Patch
M BUILD.gn View 1 2 1 chunk +20 lines, -20 lines 0 comments Download
D fpdfsdk/include/javascript/Consts.h View 1 chunk +0 lines, -116 lines 0 comments Download
D fpdfsdk/include/javascript/Document.h View 1 chunk +0 lines, -406 lines 0 comments Download
D fpdfsdk/include/javascript/Field.h View 1 2 1 chunk +0 lines, -624 lines 0 comments Download
M fpdfsdk/include/javascript/IJavaScript.h View 2 chunks +4 lines, -0 lines 0 comments Download
D fpdfsdk/include/javascript/Icon.h View 1 chunk +0 lines, -39 lines 0 comments Download
D fpdfsdk/include/javascript/JS_Context.h View 1 chunk +0 lines, -137 lines 0 comments Download
D fpdfsdk/include/javascript/JS_Define.h View 1 chunk +0 lines, -484 lines 0 comments Download
D fpdfsdk/include/javascript/JS_EventHandler.h View 1 chunk +0 lines, -220 lines 0 comments Download
D fpdfsdk/include/javascript/JS_GlobalData.h View 1 chunk +0 lines, -107 lines 0 comments Download
D fpdfsdk/include/javascript/JS_Object.h View 1 chunk +0 lines, -119 lines 0 comments Download
D fpdfsdk/include/javascript/JS_Runtime.h View 1 chunk +0 lines, -72 lines 0 comments Download
D fpdfsdk/include/javascript/JS_Value.h View 1 chunk +0 lines, -218 lines 0 comments Download
D fpdfsdk/include/javascript/PublicMethods.h View 1 chunk +0 lines, -185 lines 0 comments Download
D fpdfsdk/include/javascript/app.h View 1 chunk +0 lines, -218 lines 0 comments Download
D fpdfsdk/include/javascript/color.h View 1 2 1 chunk +0 lines, -85 lines 0 comments Download
D fpdfsdk/include/javascript/console.h View 1 chunk +0 lines, -49 lines 0 comments Download
D fpdfsdk/include/javascript/event.h View 1 chunk +0 lines, -89 lines 0 comments Download
D fpdfsdk/include/javascript/global.h View 1 chunk +0 lines, -93 lines 0 comments Download
D fpdfsdk/include/javascript/report.h View 1 chunk +0 lines, -40 lines 0 comments Download
D fpdfsdk/include/javascript/resource.h View 1 chunk +0 lines, -39 lines 0 comments Download
D fpdfsdk/include/javascript/util.h View 1 chunk +0 lines, -68 lines 0 comments Download
M fpdfsdk/src/fsdk_mgr.cpp View 2 chunks +1 line, -2 lines 0 comments Download
A + fpdfsdk/src/javascript/Consts.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Consts.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
A + fpdfsdk/src/javascript/Document.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Document.cpp View 1 2 3 1 chunk +13 lines, -12 lines 0 comments Download
A + fpdfsdk/src/javascript/Field.h View 1 2 3 2 chunks +5 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/Field.cpp View 1 2 3 1 chunk +13 lines, -11 lines 0 comments Download
A + fpdfsdk/src/javascript/Icon.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/Icon.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
A + fpdfsdk/src/javascript/JS_Context.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Context.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
A + fpdfsdk/src/javascript/JS_Define.h View 3 chunks +9 lines, -8 lines 0 comments Download
A + fpdfsdk/src/javascript/JS_EventHandler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_EventHandler.cpp View 1 2 3 1 chunk +9 lines, -8 lines 0 comments Download
A + fpdfsdk/src/javascript/JS_GlobalData.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/JS_GlobalData.cpp View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A + fpdfsdk/src/javascript/JS_Object.h View 1 2 3 2 chunks +6 lines, -9 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Object.cpp View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
A + fpdfsdk/src/javascript/JS_Runtime.h View 2 chunks +5 lines, -5 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Runtime.cpp View 1 2 3 1 chunk +25 lines, -19 lines 0 comments Download
A + fpdfsdk/src/javascript/JS_Value.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/JS_Value.cpp View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
A + fpdfsdk/src/javascript/PublicMethods.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/PublicMethods.cpp View 1 2 3 1 chunk +13 lines, -12 lines 0 comments Download
A + fpdfsdk/src/javascript/app.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/app.cpp View 1 2 3 1 chunk +11 lines, -9 lines 0 comments Download
A + fpdfsdk/src/javascript/color.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/color.cpp View 1 2 1 chunk +7 lines, -7 lines 0 comments Download
A + fpdfsdk/src/javascript/console.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/console.cpp View 1 2 1 chunk +7 lines, -6 lines 0 comments Download
A + fpdfsdk/src/javascript/event.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/event.cpp View 1 2 1 chunk +8 lines, -7 lines 0 comments Download
A + fpdfsdk/src/javascript/global.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/global.cpp View 1 2 1 chunk +9 lines, -8 lines 0 comments Download
A + fpdfsdk/src/javascript/report.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/report.cpp View 1 2 3 1 chunk +5 lines, -4 lines 0 comments Download
A + fpdfsdk/src/javascript/resource.h View 2 chunks +4 lines, -4 lines 0 comments Download
M fpdfsdk/src/javascript/resource.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + fpdfsdk/src/javascript/util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M fpdfsdk/src/javascript/util.cpp View 1 2 3 1 chunk +10 lines, -9 lines 0 comments Download
M fpdfsdk/src/jsapi/fxjs_v8_embeddertest.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M pdfium.gyp View 1 2 1 chunk +25 lines, -22 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Tom Sepez
Lei, for review. Surprisingly simple.
5 years, 2 months ago (2015-10-05 22:50:38 UTC) #2
Lei Zhang
lgtm, with lots of nits. https://codereview.chromium.org/1389783002/diff/20001/fpdfsdk/src/javascript/Document.cpp File fpdfsdk/src/javascript/Document.cpp (right): https://codereview.chromium.org/1389783002/diff/20001/fpdfsdk/src/javascript/Document.cpp#newcode14 fpdfsdk/src/javascript/Document.cpp:14: #include "JS_EventHandler.h" nit: alphabetical ...
5 years, 2 months ago (2015-10-05 23:39:25 UTC) #3
Tom Sepez
https://codereview.chromium.org/1389783002/diff/20001/fpdfsdk/src/javascript/Document.cpp File fpdfsdk/src/javascript/Document.cpp (right): https://codereview.chromium.org/1389783002/diff/20001/fpdfsdk/src/javascript/Document.cpp#newcode14 fpdfsdk/src/javascript/Document.cpp:14: #include "JS_EventHandler.h" On 2015/10/05 23:39:24, Lei Zhang wrote: > ...
5 years, 2 months ago (2015-10-06 00:10:55 UTC) #4
Lei Zhang
++lgtm https://codereview.chromium.org/1389783002/diff/20001/fpdfsdk/src/javascript/Document.cpp File fpdfsdk/src/javascript/Document.cpp (right): https://codereview.chromium.org/1389783002/diff/20001/fpdfsdk/src/javascript/Document.cpp#newcode14 fpdfsdk/src/javascript/Document.cpp:14: #include "JS_EventHandler.h" On 2015/10/06 00:10:54, Tom Sepez wrote: ...
5 years, 2 months ago (2015-10-06 00:13:46 UTC) #5
Tom Sepez
5 years, 2 months ago (2015-10-06 14:50:52 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
5b3d0208723f21c50b9922bdc500c9d78c359a25 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698