fpdfsdk/src/fsdk_mgr.cpp - Issue 1389783002: Make the vast majority of JS headers private to src/javascript.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fsdk_mgr.cpp

Issue 1389783002: Make the vast majority of JS headers private to src/javascript. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Nits. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/fsdk_mgr.cpp

diff --git a/fpdfsdk/src/fsdk_mgr.cpp b/fpdfsdk/src/fsdk_mgr.cpp

index 5b94aef600f9039bc564bcc4259fa283468fe70d..6123dc8c9ba2b83acd7624adfb5d4c775a848a26 100644

--- a/fpdfsdk/src/fsdk_mgr.cpp

+++ b/fpdfsdk/src/fsdk_mgr.cpp

@@ -10,7 +10,6 @@

#include "../include/fsdk_mgr.h"

#include "../include/formfiller/FFL_FormFiller.h"

#include "../include/javascript/IJavaScript.h"

-#include "../include/javascript/JS_Runtime.h"

#if _FX_OS_ == _FX_ANDROID_

#include "time.h"

@@ -374,7 +373,7 @@ IFXJS_Runtime* CPDFDoc_Environment::GetJSRuntime() {

if (!IsJSInitiated())

return NULL;

if (!m_pJSRuntime)

- m_pJSRuntime.reset(new CJS_Runtime(this));

+ m_pJSRuntime.reset(IFXJS_Runtime::Create(this));

return m_pJSRuntime.get();

}

« no previous file with comments | « fpdfsdk/include/javascript/util.h ('k') | fpdfsdk/src/javascript/Consts.h » ('j') | no next file with comments »