Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1389603002: Oilpan: Don't limit the number of wrappers collected in minor GC cycles (Closed)

Created:
5 years, 2 months ago by haraken
Modified:
5 years, 2 months ago
Reviewers:
oilpan-reviews, sof
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Don't limit the number of wrappers collected in minor GC cycles In Oilpan, it is better to not limit the number of wrappers collected in minor GC cycles. This may increase the pause time of a minor GC, but if we give up collecting wrappers in a minor GC, it will instead end up with increasing the cost of subsequent Oilpan's GCs. Thus it will be better to collect as many wrappers as possible for minimizing the value of max(a pause time of a minor GC, a pause time of Oilpan's GC). BUG= Committed: https://crrev.com/dba5fc94c1c009edef581ed788f954c8c980ee52 Cr-Commit-Position: refs/heads/master@{#352307}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
haraken
PTAL
5 years, 2 months ago (2015-10-05 00:01:04 UTC) #2
haraken
On 2015/10/05 00:01:04, haraken wrote: > PTAL BTW, the object grouping for a minor GC ...
5 years, 2 months ago (2015-10-05 00:02:48 UTC) #3
sof
lgtm
5 years, 2 months ago (2015-10-05 06:07:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389603002/20001
5 years, 2 months ago (2015-10-05 06:22:47 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-05 09:20:33 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 09:21:36 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dba5fc94c1c009edef581ed788f954c8c980ee52
Cr-Commit-Position: refs/heads/master@{#352307}

Powered by Google App Engine
This is Rietveld 408576698