Issue 13896018: Remove the executable bit from scanner.cc file.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13896018: Remove the executable bit from scanner.cc file. (Closed)

Created:
7 years, 8 months ago by tfarina

Modified:
7 years, 8 months ago

Reviewers:
Sven Panne

CC:
v8-dev, Jakob Kummerow, mvstanton

Base URL:
git://github.com/v8/v8.git@master

Visibility:
Public.

More Reviews

Description

Remove the executable bit from scanner.cc file. R=svenpanne@chromium.org Signed-off-by: Thiago Farina <tfarina@chromium.org>;

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+-1 lines, --1 lines)			Patch
	A	src/scanner.cc	View		0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 8 months ago (2013-04-23 07:25:05 UTC) #3

On 2013/04/23 06:44:55, Sven Panne wrote:
> LGTM. Landing it for you...

Hmmm, I had problems patching in this CL, so I landed a new one:
https://codereview.chromium.org/14081021/. Closing this CL...

Expand Messages | Collapse Messages