Devserver: run the cron over the examples.

Devserver: run the cron over the examples. Do an audit of our handling of
FileNotFoundErrors: make them all descriptive, and don't overcatch them.

NOTRY=true
BUG=226625
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195073

[not at google - send to devlin, 2013-04-18 23:24:54]

The last patch wasn't quite enough...

[cduvall, 2013-04-18 23:31:15]

lgtm

https://codereview.chromium.org/13896007/diff/5001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

https://codereview.chromium.org/13896007/diff/5001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/template_data_source.py:149:
os.path.join(base_path, FormatKey(template_name)))
might want to use '/'.join since this is a URL not a file path.

[not at google - send to devlin, 2013-04-18 23:36:36]

https://codereview.chromium.org/13896007/diff/5001/chrome/common/extensions/d...
File chrome/common/extensions/docs/server2/template_data_source.py (right):

https://codereview.chromium.org/13896007/diff/5001/chrome/common/extensions/d...
chrome/common/extensions/docs/server2/template_data_source.py:149:
os.path.join(base_path, FormatKey(template_name)))
On 2013/04/18 23:31:16, cduvall wrote:
> might want to use '/'.join since this is a URL not a file path.

oops, thanks.

[commit-bot: I haz the power, 2013-04-19 02:48:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/13896007/5004

[commit-bot: I haz the power, 2013-04-19 02:49:32]

Presubmit check for 13896007-5004 failed and returned exit status 1.

INFO:root:Found 13 file(s).

ERROR:root:extensions/examples/api/downloads/download_links/icon.png had empty
content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery-ui-1.8.4.custom.min.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.valuelabels.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.navigate.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.js had
empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.client.js had
empty content
ERROR:root:extensions/examples/apps/hello-python/oauth2/clients/__init__.py had
empty content
F.ERROR:root:File system is offline, cannot read
docs/templates/public/extensions/
.
======================================================================
FAIL: testCronAndPublicFiles (__main__.IntegrationTest)
Runs cron then requests every public file. Cron needs to be run first
----------------------------------------------------------------------
Traceback (most recent call last):
  File "docs/server2/integration_test.py", line 67, in testCronAndPublicFiles
    check_result(*self._renderer.Render(path))
  File "docs/server2/integration_test.py", line 63, in check_result
    self.assertEqual(200, render_status)
AssertionError: 200 != 404

----------------------------------------------------------------------
Ran 3 tests in 68.196s

FAILED (failures=1)
Running cron...
Took 67.8595440388 seconds
Rendering 690 public files...
Took 0.0553679466248 seconds
testGetBranchNumberForChannelName (__main__.BranchUtilityTest) ... ok
testSplitChannelNameFromPath (__main__.BranchUtilityTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.002s

OK
testLevels (__main__.SamplesDataSourceTest) ... ok
testSelected (__main__.SamplesDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK
testCheckAndReset (__main__.TestObjectStoreTest) ... ok
testEmpty (__main__.TestObjectStoreTest) ... ok
testNonEmpty (__main__.TestObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.002s

OK
testListDir (__main__.SubversionFileSystemTest) ... ok
testReadFiles (__main__.SubversionFileSystemTest) ... ok
testStat (__main__.SubversionFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.101s

OK
testFilterSamples (__main__.SamplesDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.001s

OK
testFactoryWithBranch (__main__.ObjectStoreCreatorTest) ... ok
testIllegalIinput (__main__.ObjectStoreCreatorTest) ... ok
testVanilla (__main__.ObjectStoreCreatorTest) ... ok
testWithCategory (__main__.ObjectStoreCreatorTest) ... ok
testWithVersion (__main__.ObjectStoreCreatorTest) ... ok
testWithVersionAndCategory (__main__.ObjectStoreCreatorTest) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.001s

OK
testListDir (__main__.LocalFileSystemTest) ... ok
testReadFiles (__main__.LocalFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.002s

OK
testCaching (__main__.CachingFileSystemTest) ... ok
testListDir (__main__.CachingFileSystemTest) ... ok
testReadFiles (__main__.CachingFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
testCreateZip (__main__.ExampleZipperTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.005s

OK
testNamespaceIsolation (__main__.PersistentObjectStoreTest) ... ok
testPersistence (__main__.PersistentObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK
testDel (__main__.CacheChainObjectStoreTest) ... ok
testGetFromAllLayers (__main__.CacheChainObjectStoreTest) ... ok
testGetFromFirstLayer (__main__.CacheChainObjectStoreTest) ... ok
testGetFromSecondLayer (__main__.CacheChainObjectStoreTest) ... ok
testGetFromThirdLayer (__main__.CacheChainObjectStoreTest) ... ok
testNotFound (__main__.CacheChainObjectStoreTest) ... ok
testPartiallyCachedInMemory (__main__.CacheChainObjectStoreTest) ... ok
testSet (__main__.CacheChainObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 8 tests in 0.003s

OK
testApps (__main__.APIListDataSourceTest) ... ok
testExperimentalApps (__main__.APIListDataSourceTest) ... ok
testExtensions (__main__.APIListDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.002s

OK
testKeyGeneration (__main__.GithubFileSystemTest) ... ok
testList (__main__.GithubFileSystemTest) ... ok
testRead (__main__.GithubFileSystemTest) ... ok
testStat (__main__.GithubFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.091s

OK
testCheckAndReset (__main__.TestFileSystemTest) ... ok
testEmptyFileSystem (__main__.TestFileSystemTest) ... ok
testMoveTo (__main__.TestFileSystemTest) ... ok
testNonemptyFileNotFoundErrors (__main__.TestFileSystemTest) ... ok
testNonemptySuccess (__main__.TestFileSystemTest) ... ok
testStat (__main__.TestFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.003s

OK
testPartials (__main__.TemplateDataSourceTest) ...
ERROR:root:SamplesDataSource.Factory was never set in APIDataSource.Factory.
ERROR:root:ReferenceResolver.Factory was never set in APIDataSource.Factory.
ok
testRender (__main__.TemplateDataSourceTest) ... ok
testSimple (__main__.TemplateDataSourceTest) ... ERROR:root:os.stat failed for
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/test_data/template_data_source/simple/./junk.html:
[Errno 2] No such file or directory:
'/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/test_data/template_data_source/simple/./junk.html'
ok

----------------------------------------------------------------------
Ran 3 tests in 0.012s

OK
testCaching (__main__.CompiledFileSystemTest) ... ok
testFailures (__main__.CompiledFileSystemTest) ... ok
testIdentityFromFile (__main__.CompiledFileSystemTest) ... ok
testIdentityFromFileListing (__main__.CompiledFileSystemTest) ... ok
testIdentityNamespace (__main__.CompiledFileSystemTest) ... ok
testPopulateFromFile (__main__.CompiledFileSystemTest) ... ok
testPopulateNamespace (__main__.CompiledFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 7 tests in 0.003s

OK
testGetLink (__main__.APIDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.003s

OK
testApps (__main__.PathCanonicalizerTest) ... ok
testExtensions (__main__.PathCanonicalizerTest) ... ok
testNeither (__main__.PathCanonicalizerTest) ... ok
testStatic (__main__.PathCanonicalizerTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.002s

OK
testCreateId (__main__.APIDataSourceTest) ... ok
testFormatDescription (__main__.APIDataSourceTest) ... ok
testFormatValue (__main__.APIDataSourceTest) ... ok
testRemoveNoDocs (__main__.APIDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.006s

OK
testIntro (__main__.IntroDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.004s

OK
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py
Running
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/PRESUBMIT.py
Running ./branch_utility_test.py
Running ./sidenav_data_source_test.py
Running ./test_object_store_test.py
Running ./subversion_file_system_test.py
Running ./samples_data_source_test.py
Running ./object_store_creator_test.py
Running ./local_file_system_test.py
Running ./caching_file_system_test.py
Running ./example_zipper_test.py
Running ./persistent_object_store_test.py
Running ./cache_chain_object_store_test.py
Running ./api_list_data_source_test.py
Running ./github_file_system_test.py
Running ./test_file_system_test.py
Running ./template_data_source_test.py
Running ./compiled_file_system_test.py
Running ./reference_resolver_test.py
Running ./path_canonicalizer_test.py
Running ./api_data_source_test.py
Running ./intro_data_source_test.py

** Presubmit Warnings **
_VERSION of chrome/common/extensions/docs/server2/api_data_source.py needs to be
incremented.

_VERSION of chrome/common/extensions/docs/server2/api_list_data_source.py needs
to be incremented.

_VERSION of chrome/common/extensions/docs/server2/example_zipper.py needs to be
incremented.

_VERSION of chrome/common/extensions/docs/server2/sidenav_data_source.py needs
to be incremented.

_VERSION of chrome/common/extensions/docs/server2/subversion_file_system.py
needs to be incremented.

_VERSION of chrome/common/extensions/docs/server2/template_data_source.py needs
to be incremented.

** Presubmit ERRORS **
IntegrationTest failed!

Presubmit checks took 71.3s to calculate.

[commit-bot: I haz the power, 2013-04-19 03:08:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/13896007/12001

[commit-bot: I haz the power, 2013-04-19 03:09:08]

Presubmit check for 13896007-12001 failed and returned exit status 1.

INFO:root:Found 14 file(s).

ERROR:root:extensions/examples/api/downloads/download_links/icon.png had empty
content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery-ui-1.8.4.custom.min.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.valuelabels.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.navigate.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.js had
empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.client.js had
empty content
ERROR:root:extensions/examples/apps/hello-python/oauth2/clients/__init__.py had
empty content
F.ERROR:root:File system is offline, cannot read
docs/templates/public/extensions/
.
======================================================================
FAIL: testCronAndPublicFiles (__main__.IntegrationTest)
Runs cron then requests every public file. Cron needs to be run first
----------------------------------------------------------------------
Traceback (most recent call last):
  File "docs/server2/integration_test.py", line 69, in testCronAndPublicFiles
    check_result(*self._renderer.Render(path))
  File "docs/server2/integration_test.py", line 64, in check_result
    'Got %s when rendering %s' % (render_status, path))
AssertionError: Got 404 when rendering
apps/.svn/text-base/experimental_devtools_inspectedWindow.html.svn-base

----------------------------------------------------------------------
Ran 3 tests in 50.153s

FAILED (failures=1)
Running cron...
Took 50.0768151283 seconds
Rendering 690 public files...
Took 0.0471589565277 seconds
testGetBranchNumberForChannelName (__main__.BranchUtilityTest) ... ok
testSplitChannelNameFromPath (__main__.BranchUtilityTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.002s

OK
testLevels (__main__.SamplesDataSourceTest) ... ok
testSelected (__main__.SamplesDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK
testCheckAndReset (__main__.TestObjectStoreTest) ... ok
testEmpty (__main__.TestObjectStoreTest) ... ok
testNonEmpty (__main__.TestObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.001s

OK
testListDir (__main__.SubversionFileSystemTest) ... ok
testReadFiles (__main__.SubversionFileSystemTest) ... ok
testStat (__main__.SubversionFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.101s

OK
testFilterSamples (__main__.SamplesDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.001s

OK
testFactoryWithBranch (__main__.ObjectStoreCreatorTest) ... ok
testIllegalIinput (__main__.ObjectStoreCreatorTest) ... ok
testVanilla (__main__.ObjectStoreCreatorTest) ... ok
testWithCategory (__main__.ObjectStoreCreatorTest) ... ok
testWithVersion (__main__.ObjectStoreCreatorTest) ... ok
testWithVersionAndCategory (__main__.ObjectStoreCreatorTest) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.001s

OK
testListDir (__main__.LocalFileSystemTest) ... ok
testReadFiles (__main__.LocalFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.002s

OK
testCaching (__main__.CachingFileSystemTest) ... ok
testListDir (__main__.CachingFileSystemTest) ... ok
testReadFiles (__main__.CachingFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
testCreateZip (__main__.ExampleZipperTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.005s

OK
testNamespaceIsolation (__main__.PersistentObjectStoreTest) ... ok
testPersistence (__main__.PersistentObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK
testDel (__main__.CacheChainObjectStoreTest) ... ok
testGetFromAllLayers (__main__.CacheChainObjectStoreTest) ... ok
testGetFromFirstLayer (__main__.CacheChainObjectStoreTest) ... ok
testGetFromSecondLayer (__main__.CacheChainObjectStoreTest) ... ok
testGetFromThirdLayer (__main__.CacheChainObjectStoreTest) ... ok
testNotFound (__main__.CacheChainObjectStoreTest) ... ok
testPartiallyCachedInMemory (__main__.CacheChainObjectStoreTest) ... ok
testSet (__main__.CacheChainObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 8 tests in 0.003s

OK
testApps (__main__.APIListDataSourceTest) ... ok
testExperimentalApps (__main__.APIListDataSourceTest) ... ok
testExtensions (__main__.APIListDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.002s

OK
testKeyGeneration (__main__.GithubFileSystemTest) ... ok
testList (__main__.GithubFileSystemTest) ... ok
testRead (__main__.GithubFileSystemTest) ... ok
testStat (__main__.GithubFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.090s

OK
testCheckAndReset (__main__.TestFileSystemTest) ... ok
testEmptyFileSystem (__main__.TestFileSystemTest) ... ok
testMoveTo (__main__.TestFileSystemTest) ... ok
testNonemptyFileNotFoundErrors (__main__.TestFileSystemTest) ... ok
testNonemptySuccess (__main__.TestFileSystemTest) ... ok
testStat (__main__.TestFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.002s

OK
testPartials (__main__.TemplateDataSourceTest) ...
ERROR:root:SamplesDataSource.Factory was never set in APIDataSource.Factory.
ERROR:root:ReferenceResolver.Factory was never set in APIDataSource.Factory.
ok
testRender (__main__.TemplateDataSourceTest) ... ok
testSimple (__main__.TemplateDataSourceTest) ... ERROR:root:os.stat failed for
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/test_data/template_data_source/simple/./junk.html:
[Errno 2] No such file or directory:
'/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/test_data/template_data_source/simple/./junk.html'
ok

----------------------------------------------------------------------
Ran 3 tests in 0.014s

OK
testCaching (__main__.CompiledFileSystemTest) ... ok
testFailures (__main__.CompiledFileSystemTest) ... ok
testIdentityFromFile (__main__.CompiledFileSystemTest) ... ok
testIdentityFromFileListing (__main__.CompiledFileSystemTest) ... ok
testIdentityNamespace (__main__.CompiledFileSystemTest) ... ok
testPopulateFromFile (__main__.CompiledFileSystemTest) ... ok
testPopulateNamespace (__main__.CompiledFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 7 tests in 0.004s

OK
testGetLink (__main__.APIDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.003s

OK
testApps (__main__.PathCanonicalizerTest) ... ok
testExtensions (__main__.PathCanonicalizerTest) ... ok
testNeither (__main__.PathCanonicalizerTest) ... ok
testStatic (__main__.PathCanonicalizerTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.002s

OK
testCreateId (__main__.APIDataSourceTest) ... ok
testFormatDescription (__main__.APIDataSourceTest) ... ok
testFormatValue (__main__.APIDataSourceTest) ... ok
testRemoveNoDocs (__main__.APIDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.006s

OK
testIntro (__main__.IntroDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.004s

OK
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py
Running
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/PRESUBMIT.py
Running ./branch_utility_test.py
Running ./sidenav_data_source_test.py
Running ./test_object_store_test.py
Running ./subversion_file_system_test.py
Running ./samples_data_source_test.py
Running ./object_store_creator_test.py
Running ./local_file_system_test.py
Running ./caching_file_system_test.py
Running ./example_zipper_test.py
Running ./persistent_object_store_test.py
Running ./cache_chain_object_store_test.py
Running ./api_list_data_source_test.py
Running ./github_file_system_test.py
Running ./test_file_system_test.py
Running ./template_data_source_test.py
Running ./compiled_file_system_test.py
Running ./reference_resolver_test.py
Running ./path_canonicalizer_test.py
Running ./api_data_source_test.py
Running ./intro_data_source_test.py

** Presubmit Warnings **
_VERSION of chrome/common/extensions/docs/server2/api_data_source.py needs to be
incremented.

_VERSION of chrome/common/extensions/docs/server2/api_list_data_source.py needs
to be incremented.

_VERSION of chrome/common/extensions/docs/server2/example_zipper.py needs to be
incremented.

_VERSION of chrome/common/extensions/docs/server2/sidenav_data_source.py needs
to be incremented.

_VERSION of chrome/common/extensions/docs/server2/subversion_file_system.py
needs to be incremented.

_VERSION of chrome/common/extensions/docs/server2/template_data_source.py needs
to be incremented.

** Presubmit ERRORS **
IntegrationTest failed!

Presubmit checks took 54.2s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2013-04-19 03:16:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/13896007/14001

[commit-bot: I haz the power, 2013-04-19 03:17:52]

Presubmit check for 13896007-14001 failed and returned exit status 1.

INFO:root:Found 14 file(s).

ERROR:root:extensions/examples/api/downloads/download_links/icon.png had empty
content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery-ui-1.8.4.custom.min.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.valuelabels.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.navigate.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.js had
empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.client.js had
empty content
ERROR:root:extensions/examples/apps/hello-python/oauth2/clients/__init__.py had
empty content
F.ERROR:root:File system is offline, cannot read
docs/templates/public/extensions/
.
======================================================================
FAIL: testCronAndPublicFiles (__main__.IntegrationTest)
Runs cron then requests every public file. Cron needs to be run first
----------------------------------------------------------------------
Traceback (most recent call last):
  File "docs/server2/integration_test.py", line 69, in testCronAndPublicFiles
    check_result(*self._renderer.Render(path))
  File "docs/server2/integration_test.py", line 64, in check_result
    'Got %s when rendering %s' % (render_status, path))
AssertionError: Got 404 when rendering
apps/.svn/text-base/experimental_devtools_inspectedWindow.html.svn-base

----------------------------------------------------------------------
Ran 3 tests in 49.969s

FAILED (failures=1)
Running cron...
Took 49.8936982155 seconds
Rendering 690 public files...
Took 0.0462000370026 seconds
testGetBranchNumberForChannelName (__main__.BranchUtilityTest) ... ok
testSplitChannelNameFromPath (__main__.BranchUtilityTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.002s

OK
testLevels (__main__.SamplesDataSourceTest) ... ok
testSelected (__main__.SamplesDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK
testCheckAndReset (__main__.TestObjectStoreTest) ... ok
testEmpty (__main__.TestObjectStoreTest) ... ok
testNonEmpty (__main__.TestObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.002s

OK
testListDir (__main__.SubversionFileSystemTest) ... ok
testReadFiles (__main__.SubversionFileSystemTest) ... ok
testStat (__main__.SubversionFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.098s

OK
testFilterSamples (__main__.SamplesDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.001s

OK
testFactoryWithBranch (__main__.ObjectStoreCreatorTest) ... ok
testIllegalIinput (__main__.ObjectStoreCreatorTest) ... ok
testVanilla (__main__.ObjectStoreCreatorTest) ... ok
testWithCategory (__main__.ObjectStoreCreatorTest) ... ok
testWithVersion (__main__.ObjectStoreCreatorTest) ... ok
testWithVersionAndCategory (__main__.ObjectStoreCreatorTest) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.001s

OK
testListDir (__main__.LocalFileSystemTest) ... ok
testReadFiles (__main__.LocalFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.002s

OK
testCaching (__main__.CachingFileSystemTest) ... ok
testListDir (__main__.CachingFileSystemTest) ... ok
testReadFiles (__main__.CachingFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
testCreateZip (__main__.ExampleZipperTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.005s

OK
testNamespaceIsolation (__main__.PersistentObjectStoreTest) ... ok
testPersistence (__main__.PersistentObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK
testDel (__main__.CacheChainObjectStoreTest) ... ok
testGetFromAllLayers (__main__.CacheChainObjectStoreTest) ... ok
testGetFromFirstLayer (__main__.CacheChainObjectStoreTest) ... ok
testGetFromSecondLayer (__main__.CacheChainObjectStoreTest) ... ok
testGetFromThirdLayer (__main__.CacheChainObjectStoreTest) ... ok
testNotFound (__main__.CacheChainObjectStoreTest) ... ok
testPartiallyCachedInMemory (__main__.CacheChainObjectStoreTest) ... ok
testSet (__main__.CacheChainObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 8 tests in 0.003s

OK
testApps (__main__.APIListDataSourceTest) ... ok
testExperimentalApps (__main__.APIListDataSourceTest) ... ok
testExtensions (__main__.APIListDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.002s

OK
testKeyGeneration (__main__.GithubFileSystemTest) ... ok
testList (__main__.GithubFileSystemTest) ... ok
testRead (__main__.GithubFileSystemTest) ... ok
testStat (__main__.GithubFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.092s

OK
testCheckAndReset (__main__.TestFileSystemTest) ... ok
testEmptyFileSystem (__main__.TestFileSystemTest) ... ok
testMoveTo (__main__.TestFileSystemTest) ... ok
testNonemptyFileNotFoundErrors (__main__.TestFileSystemTest) ... ok
testNonemptySuccess (__main__.TestFileSystemTest) ... ok
testStat (__main__.TestFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.002s

OK
testPartials (__main__.TemplateDataSourceTest) ...
ERROR:root:SamplesDataSource.Factory was never set in APIDataSource.Factory.
ERROR:root:ReferenceResolver.Factory was never set in APIDataSource.Factory.
ok
testRender (__main__.TemplateDataSourceTest) ... ok
testSimple (__main__.TemplateDataSourceTest) ... ERROR:root:os.stat failed for
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/test_data/template_data_source/simple/./junk.html:
[Errno 2] No such file or directory:
'/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/test_data/template_data_source/simple/./junk.html'
ok

----------------------------------------------------------------------
Ran 3 tests in 0.012s

OK
testCaching (__main__.CompiledFileSystemTest) ... ok
testFailures (__main__.CompiledFileSystemTest) ... ok
testIdentityFromFile (__main__.CompiledFileSystemTest) ... ok
testIdentityFromFileListing (__main__.CompiledFileSystemTest) ... ok
testIdentityNamespace (__main__.CompiledFileSystemTest) ... ok
testPopulateFromFile (__main__.CompiledFileSystemTest) ... ok
testPopulateNamespace (__main__.CompiledFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 7 tests in 0.003s

OK
testGetLink (__main__.APIDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.003s

OK
testApps (__main__.PathCanonicalizerTest) ... ok
testExtensions (__main__.PathCanonicalizerTest) ... ok
testNeither (__main__.PathCanonicalizerTest) ... ok
testStatic (__main__.PathCanonicalizerTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.002s

OK
testCreateId (__main__.APIDataSourceTest) ... ok
testFormatDescription (__main__.APIDataSourceTest) ... ok
testFormatValue (__main__.APIDataSourceTest) ... ok
testRemoveNoDocs (__main__.APIDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.007s

OK
testIntro (__main__.IntroDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.004s

OK
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py
Running
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/PRESUBMIT.py
Running ./branch_utility_test.py
Running ./sidenav_data_source_test.py
Running ./test_object_store_test.py
Running ./subversion_file_system_test.py
Running ./samples_data_source_test.py
Running ./object_store_creator_test.py
Running ./local_file_system_test.py
Running ./caching_file_system_test.py
Running ./example_zipper_test.py
Running ./persistent_object_store_test.py
Running ./cache_chain_object_store_test.py
Running ./api_list_data_source_test.py
Running ./github_file_system_test.py
Running ./test_file_system_test.py
Running ./template_data_source_test.py
Running ./compiled_file_system_test.py
Running ./reference_resolver_test.py
Running ./path_canonicalizer_test.py
Running ./api_data_source_test.py
Running ./intro_data_source_test.py

** Presubmit Warnings **
_VERSION of chrome/common/extensions/docs/server2/api_data_source.py needs to be
incremented.

_VERSION of chrome/common/extensions/docs/server2/api_list_data_source.py needs
to be incremented.

_VERSION of chrome/common/extensions/docs/server2/example_zipper.py needs to be
incremented.

_VERSION of chrome/common/extensions/docs/server2/sidenav_data_source.py needs
to be incremented.

_VERSION of chrome/common/extensions/docs/server2/subversion_file_system.py
needs to be incremented.

_VERSION of chrome/common/extensions/docs/server2/template_data_source.py needs
to be incremented.

** Presubmit ERRORS **
IntegrationTest failed!

Presubmit checks took 54.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[commit-bot: I haz the power, 2013-04-19 03:30:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kalman@chromium.org/13896007/2002

[commit-bot: I haz the power, 2013-04-19 03:31:51]

Presubmit check for 13896007-2002 failed and returned exit status 1.

INFO:root:Found 14 file(s).

ERROR:root:extensions/examples/api/downloads/download_links/icon.png had empty
content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery-ui-1.8.4.custom.min.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.valuelabels.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.navigate.js
had empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.flot.js had
empty content
ERROR:root:extensions/examples/extensions/benchmark/jquery/jquery.client.js had
empty content
ERROR:root:extensions/examples/apps/hello-python/oauth2/clients/__init__.py had
empty content
..ERROR:root:File system is offline, cannot read
docs/templates/public/extensions/
.
----------------------------------------------------------------------
Ran 3 tests in 56.104s

OK
Running cron...
Took 49.7579381466 seconds
Rendering 234 public files...
Took 6.33757901192 seconds
testGetBranchNumberForChannelName (__main__.BranchUtilityTest) ... ok
testSplitChannelNameFromPath (__main__.BranchUtilityTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.003s

OK
testLevels (__main__.SamplesDataSourceTest) ... ok
testSelected (__main__.SamplesDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK
testCheckAndReset (__main__.TestObjectStoreTest) ... ok
testEmpty (__main__.TestObjectStoreTest) ... ok
testNonEmpty (__main__.TestObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.003s

OK
testListDir (__main__.SubversionFileSystemTest) ... ok
testReadFiles (__main__.SubversionFileSystemTest) ... ok
testStat (__main__.SubversionFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.107s

OK
testFilterSamples (__main__.SamplesDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.001s

OK
testFactoryWithBranch (__main__.ObjectStoreCreatorTest) ... ok
testIllegalIinput (__main__.ObjectStoreCreatorTest) ... ok
testVanilla (__main__.ObjectStoreCreatorTest) ... ok
testWithCategory (__main__.ObjectStoreCreatorTest) ... ok
testWithVersion (__main__.ObjectStoreCreatorTest) ... ok
testWithVersionAndCategory (__main__.ObjectStoreCreatorTest) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.001s

OK
testListDir (__main__.LocalFileSystemTest) ... ok
testReadFiles (__main__.LocalFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.002s

OK
testCaching (__main__.CachingFileSystemTest) ... ok
testListDir (__main__.CachingFileSystemTest) ... ok
testReadFiles (__main__.CachingFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.004s

OK
testCreateZip (__main__.ExampleZipperTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.005s

OK
testNamespaceIsolation (__main__.PersistentObjectStoreTest) ... ok
testPersistence (__main__.PersistentObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 2 tests in 0.001s

OK
testDel (__main__.CacheChainObjectStoreTest) ... ok
testGetFromAllLayers (__main__.CacheChainObjectStoreTest) ... ok
testGetFromFirstLayer (__main__.CacheChainObjectStoreTest) ... ok
testGetFromSecondLayer (__main__.CacheChainObjectStoreTest) ... ok
testGetFromThirdLayer (__main__.CacheChainObjectStoreTest) ... ok
testNotFound (__main__.CacheChainObjectStoreTest) ... ok
testPartiallyCachedInMemory (__main__.CacheChainObjectStoreTest) ... ok
testSet (__main__.CacheChainObjectStoreTest) ... ok

----------------------------------------------------------------------
Ran 8 tests in 0.003s

OK
testApps (__main__.APIListDataSourceTest) ... ok
testExperimentalApps (__main__.APIListDataSourceTest) ... ok
testExtensions (__main__.APIListDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 3 tests in 0.002s

OK
testKeyGeneration (__main__.GithubFileSystemTest) ... ok
testList (__main__.GithubFileSystemTest) ... ok
testRead (__main__.GithubFileSystemTest) ... ok
testStat (__main__.GithubFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.093s

OK
testCheckAndReset (__main__.TestFileSystemTest) ... ok
testEmptyFileSystem (__main__.TestFileSystemTest) ... ok
testMoveTo (__main__.TestFileSystemTest) ... ok
testNonemptyFileNotFoundErrors (__main__.TestFileSystemTest) ... ok
testNonemptySuccess (__main__.TestFileSystemTest) ... ok
testStat (__main__.TestFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 6 tests in 0.003s

OK
testPartials (__main__.TemplateDataSourceTest) ...
ERROR:root:SamplesDataSource.Factory was never set in APIDataSource.Factory.
ERROR:root:ReferenceResolver.Factory was never set in APIDataSource.Factory.
ok
testRender (__main__.TemplateDataSourceTest) ... ok
testSimple (__main__.TemplateDataSourceTest) ... ERROR:root:os.stat failed for
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/test_data/template_data_source/simple/./junk.html:
[Errno 2] No such file or directory:
'/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/test_data/template_data_source/simple/./junk.html'
ok

----------------------------------------------------------------------
Ran 3 tests in 0.012s

OK
testCaching (__main__.CompiledFileSystemTest) ... ok
testFailures (__main__.CompiledFileSystemTest) ... ok
testIdentityFromFile (__main__.CompiledFileSystemTest) ... ok
testIdentityFromFileListing (__main__.CompiledFileSystemTest) ... ok
testIdentityNamespace (__main__.CompiledFileSystemTest) ... ok
testPopulateFromFile (__main__.CompiledFileSystemTest) ... ok
testPopulateNamespace (__main__.CompiledFileSystemTest) ... ok

----------------------------------------------------------------------
Ran 7 tests in 0.003s

OK
testGetLink (__main__.APIDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.003s

OK
testApps (__main__.PathCanonicalizerTest) ... ok
testExtensions (__main__.PathCanonicalizerTest) ... ok
testNeither (__main__.PathCanonicalizerTest) ... ok
testStatic (__main__.PathCanonicalizerTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.002s

OK
testCreateId (__main__.APIDataSourceTest) ... ok
testFormatDescription (__main__.APIDataSourceTest) ... ok
testFormatValue (__main__.APIDataSourceTest) ... ok
testRemoveNoDocs (__main__.APIDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 4 tests in 0.007s

OK
testIntro (__main__.IntroDataSourceTest) ... ok

----------------------------------------------------------------------
Ran 1 test in 0.004s

OK
Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/common/extensions/PRESUBMIT.py
Running
/b/commit-queue/workdir/chromium/chrome/common/extensions/docs/server2/PRESUBMIT.py
Running ./branch_utility_test.py
Running ./sidenav_data_source_test.py
Running ./test_object_store_test.py
Running ./subversion_file_system_test.py
Running ./samples_data_source_test.py
Running ./object_store_creator_test.py
Running ./local_file_system_test.py
Running ./caching_file_system_test.py
Running ./example_zipper_test.py
Running ./persistent_object_store_test.py
Running ./cache_chain_object_store_test.py
Running ./api_list_data_source_test.py
Running ./github_file_system_test.py
Running ./test_file_system_test.py
Running ./template_data_source_test.py
Running ./compiled_file_system_test.py
Running ./reference_resolver_test.py
Running ./path_canonicalizer_test.py
Running ./api_data_source_test.py
Running ./intro_data_source_test.py

** Presubmit Warnings **
_VERSION of chrome/common/extensions/docs/server2/api_data_source.py needs to be
incremented.

_VERSION of chrome/common/extensions/docs/server2/api_list_data_source.py needs
to be incremented.

_VERSION of chrome/common/extensions/docs/server2/example_zipper.py needs to be
incremented.

_VERSION of chrome/common/extensions/docs/server2/sidenav_data_source.py needs
to be incremented.

_VERSION of chrome/common/extensions/docs/server2/subversion_file_system.py
needs to be incremented.

_VERSION of chrome/common/extensions/docs/server2/template_data_source.py needs
to be incremented.

Presubmit checks took 59.3s to calculate.

[not at google - send to devlin, 2013-04-19 03:35:33]

Committed patchset #7 manually as r195073.