Devserver: run the cron over the examples.

chrome/common/extensions/docs/server2/handler.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 from StringIO import StringIO
 
 from appengine_wrappers import webapp
 from appengine_wrappers import memcache
@@ skipping 79 matching lines @@
         self.headers = {}
         self.path = path
         self.url = '//localhost/%s' % path
 
     channel = path.split('/')[-1]
     logging.info('cron/%s: starting' % channel)
 
     server_instance = ServerInstance.GetOrCreateOnline(channel)
 
     def run_cron_for_dir(d, path_prefix=''):
-      error = None
+      success = True
       start_time = time.time()
       files = [f for f in server_instance.content_cache.GetFromFileListing(d)
                if not f.endswith('/')]
       for f in files:
+        error = None
         path = '%s%s' % (path_prefix, f)
         try:
           response = MockResponse()
           server_instance.Get(path, MockRequest(path), response)
           if response.status != 200:
             error = 'Got %s response' % response.status
         except error:
           pass
         if error:
           logging.error('cron/%s: error rendering %s: %s' % (
               channel, path, error))
+          success = False
       logging.info('cron/%s: rendering %s files took %s seconds' % (
           channel, len(files), time.time() - start_time))
-      return error
+      return success
 
     # Don't use "or" since we want to evaluate everything no matter what.
-    was_error = any((
+    success = any((
+        # Note: rendering the public templates will pull in all of the private
+        # templates.
         run_cron_for_dir(svn_constants.PUBLIC_TEMPLATE_PATH),
-        run_cron_for_dir(svn_constants.STATIC_PATH, path_prefix='static/')))
+        run_cron_for_dir(svn_constants.STATIC_PATH, path_prefix='static/'),
+        # Note: rendering the public templates will have pulled in the .js and
+        # manifest.json files (for listing examples on the API reference pages),
+        # but there are still images, CSS, etc.
+        run_cron_for_dir(svn_constants.EXAMPLES_PATH,
+                         path_prefix='extensions/examples/')))
 
-    if was_error:
+    if success:
+      self.response.status = 200
+      self.response.out.write('Success')
+    else:
       self.response.status = 500
       self.response.out.write('Failure')
-    else:
-      self.response.status = 200
-      self.response.out.write('Success')
 
     logging.info('cron/%s: finished' % channel)
 
   def _RedirectSpecialCases(self, path):
     google_dev_url = 'http://developer.google.com/chrome'
     if path == '/' or path == '/index.html':
       self.redirect(google_dev_url)
       return True
 
     if path == '/apps.html':
@@ skipping 20 matching lines @@
       if channel in path:
         position = path.index(channel)
         path.pop(position)
         path.insert(0, channel)
     new_url += '/'.join(path)
     self.redirect(new_url)
     return True
 
   def get(self):
     path = self.request.path
+
+    if path in ['favicon.ico', 'robots.txt']:
+      response.set_status(404)
+      return
+
     if self._RedirectSpecialCases(path):
       return
 
     if path.startswith('/cron'):
       self._HandleCron(path)
       return
 
     # Redirect paths like "directory" to "directory/". This is so relative
     # file paths will know to treat this as a directory.
     if os.path.splitext(path)[1] == '' and path[-1] != '/':
       self.redirect(path + '/')
       return
 
     path = path.strip('/')
     if self._RedirectFromCodeDotGoogleDotCom(path):
       return
 
     self._HandleGet(path)