Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 138943007: Experimental parser: add a possibility to run lexing tests for truncated files. (Closed)

Created:
6 years, 11 months ago by marja
Modified:
6 years, 11 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

Experimental parser: add a possibility to run lexing tests for truncated files. R=ulan@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18825

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review (ulan) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -59 lines) Patch
M src/lexer/lexer-shell.cc View 1 10 chunks +87 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
lgtm https://codereview.chromium.org/138943007/diff/1/src/lexer/lexer-shell.cc File src/lexer/lexer-shell.cc (right): https://codereview.chromium.org/138943007/diff/1/src/lexer/lexer-shell.cc#newcode496 src/lexer/lexer-shell.cc:496: do { for loop would be also possible ...
6 years, 11 months ago (2014-01-24 12:57:39 UTC) #1
marja
https://codereview.chromium.org/138943007/diff/1/src/lexer/lexer-shell.cc File src/lexer/lexer-shell.cc (right): https://codereview.chromium.org/138943007/diff/1/src/lexer/lexer-shell.cc#newcode496 src/lexer/lexer-shell.cc:496: do { On 2014/01/24 12:57:39, ulan wrote: > for ...
6 years, 11 months ago (2014-01-24 14:10:18 UTC) #2
marja
6 years, 11 months ago (2014-01-24 14:10:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r18825 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698