Issue 138943003: Check for NaN when creating a DelayNode for WebAudio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 138943003: Check for NaN when creating a DelayNode for WebAudio (Closed)

Created:
6 years, 11 months ago by Raymond Toy (Google)

Modified:
6 years, 11 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
blink-reviews, Raymond Toy

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Description

Check for NaN when creating a DelayNode for WebAudio In createDelay(), throw an exception if the specified delay is NaN. Check a few other places for NaN where we are creating a buffer based on that value. Update a layout test to check that createDelay(NaN) throws an exception. BUG=334083 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165186

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 11 months ago

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -5 lines)
M	LayoutTests/webaudio/delaynode-maxdelaylimit.html	View	1 chunk	+1 line, -0 lines	0 comments
M	LayoutTests/webaudio/delaynode-maxdelaylimit-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments
M	Source/modules/webaudio/DelayDSPKernel.cpp	View	2 chunks	+3 lines, -2 lines	0 comments
M	Source/modules/webaudio/DelayNode.cpp	View	2 chunks	+2 lines, -1 line	0 comments
M	Source/platform/audio/AudioDelayDSPKernel.cpp	View	2 chunks	+3 lines, -2 lines	0 comments

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Raymond Toy (Google)

On 2014/01/16 02:51:13, Ken Russell wrote: > lgtm Thanks!

6 years, 11 months ago (2014-01-16 03:04:59 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/138943003/30001

6 years, 11 months ago (2014-01-16 03:05:17 UTC) #4

Message was sent while issue was closed.

Change committed as 165186

Expand Messages | Collapse Messages