Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 138943003: Check for NaN when creating a DelayNode for WebAudio (Closed)

Created:
6 years, 11 months ago by Raymond Toy (Google)
Modified:
6 years, 11 months ago
CC:
blink-reviews, Raymond Toy
Visibility:
Public.

Description

Check for NaN when creating a DelayNode for WebAudio In createDelay(), throw an exception if the specified delay is NaN. Check a few other places for NaN where we are creating a buffer based on that value. Update a layout test to check that createDelay(NaN) throws an exception. BUG=334083 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165186

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M LayoutTests/webaudio/delaynode-maxdelaylimit.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/webaudio/delaynode-maxdelaylimit-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/webaudio/DelayDSPKernel.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download
M Source/modules/webaudio/DelayNode.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/platform/audio/AudioDelayDSPKernel.cpp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Raymond Toy (Google)
PTAL.
6 years, 11 months ago (2014-01-15 23:44:35 UTC) #1
Ken Russell (switch to Gerrit)
lgtm
6 years, 11 months ago (2014-01-16 02:51:13 UTC) #2
Raymond Toy (Google)
On 2014/01/16 02:51:13, Ken Russell wrote: > lgtm Thanks!
6 years, 11 months ago (2014-01-16 03:04:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/138943003/30001
6 years, 11 months ago (2014-01-16 03:05:17 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 03:11:27 UTC) #5
Message was sent while issue was closed.
Change committed as 165186

Powered by Google App Engine
This is Rietveld 408576698