Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1108)

Unified Diff: Source/modules/webaudio/DelayDSPKernel.cpp

Issue 138943003: Check for NaN when creating a DelayNode for WebAudio (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/webaudio/delaynode-maxdelaylimit-expected.txt ('k') | Source/modules/webaudio/DelayNode.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/webaudio/DelayDSPKernel.cpp
diff --git a/Source/modules/webaudio/DelayDSPKernel.cpp b/Source/modules/webaudio/DelayDSPKernel.cpp
index 05b8cc566fdecd8cf9cdd3fc92a5c900456ee746..2301325f95b0cd34dd9a7dfedd0f6305224029b8 100644
--- a/Source/modules/webaudio/DelayDSPKernel.cpp
+++ b/Source/modules/webaudio/DelayDSPKernel.cpp
@@ -29,6 +29,7 @@
#include "modules/webaudio/DelayDSPKernel.h"
#include "platform/audio/AudioUtilities.h"
+#include "wtf/MathExtras.h"
#include <algorithm>
using namespace std;
@@ -45,8 +46,8 @@ DelayDSPKernel::DelayDSPKernel(DelayProcessor* processor)
return;
m_maxDelayTime = processor->maxDelayTime();
- ASSERT(m_maxDelayTime >= 0);
- if (m_maxDelayTime < 0)
+ ASSERT(m_maxDelayTime >= 0 && !std::isnan(m_maxDelayTime));
+ if (m_maxDelayTime < 0 || std::isnan(m_maxDelayTime))
return;
m_buffer.allocate(bufferLengthForDelay(m_maxDelayTime, processor->sampleRate()));
« no previous file with comments | « LayoutTests/webaudio/delaynode-maxdelaylimit-expected.txt ('k') | Source/modules/webaudio/DelayNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698