[rAC, OSX] Adjust red outline for NSPopUpButtons

chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm

Index: chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm
diff --git a/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm b/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm
index bdfcd80d754fef12497b464b617ac4ef6f908b17..99fd68b2cc8062ad967e189611b21ecb7342c23a 100644
--- a/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm
+++ b/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm
@@ -91,9 +91,9 @@
     NSBezierPath* path = [NSBezierPath
         bezierPathWithRoundedRect:
             NSOffsetRect(
-                NSInsetRect(NSIntegralRect(frame), 3.5, 3.5), -1.0, -1.0)
-                          xRadius:4.0
-                          yRadius:4.0];
+                NSInsetRect(frame, 3.0, 3.5), -.5, -1.0)

[Robert Sesek, 2014/01/14 22:52:17]

nit: join with previous line?

[Robert Sesek, 2014/01/14 22:52:17]

Why remove NSIntegralRect?

[groby-ooo-7-16, 2014/01/14 23:14:55]

Because the two other NSIntegral rects guarantee we'll never have non-integral
ones here. (And they also agree that both the bezel _and_ the highlight are
integral, which caused part of the mismatch before)

[groby-ooo-7-16, 2014/01/14 23:14:55]

Done. Actually, pulled out the rect computation for slightly saner indentation.

[Robert Sesek, 2014/01/14 23:18:37]

That's what I thought, just wanted to make sure.

+                          xRadius:3.5
+                          yRadius:3.5];
     [path setLineWidth:0];
     [[NSColor redColor] setStroke];
     [path stroke];