[rAC, OSX] Adjust red outline for NSPopUpButtons

chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.h"
 
 #include <ApplicationServices/ApplicationServices.h>
 
 #include "base/mac/scoped_nsobject.h"
 #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h"
@@ skipping 73 matching lines @@
 @synthesize defaultValue = defaultValue_;
 
 // Draw a bezel that's highlighted.
 - (void)drawBezelWithFrame:(NSRect)frame inView:(NSView*)controlView {
  [super drawBezelWithFrame:frame inView:controlView];
   if (invalid_) {
     // Mimic the rounded rect of default popup bezel in size, outline in red.
     NSBezierPath* path = [NSBezierPath
         bezierPathWithRoundedRect:
             NSOffsetRect(
-                NSInsetRect(NSIntegralRect(frame), 3.5, 3.5), -1.0, -1.0)
-                          xRadius:4.0
-                          yRadius:4.0];
+                NSInsetRect(frame, 3.0, 3.5), -.5, -1.0)

[Robert Sesek, 2014/01/14 22:52:17]

nit: join with previous line?

[Robert Sesek, 2014/01/14 22:52:17]

Why remove NSIntegralRect?

[groby-ooo-7-16, 2014/01/14 23:14:55]

Because the two other NSIntegral rects guarantee we'll never have non-integral
ones here. (And they also agree that both the bezel _and_ the highlight are
integral, which caused part of the mismatch before)

[groby-ooo-7-16, 2014/01/14 23:14:55]

Done. Actually, pulled out the rect computation for slightly saner indentation.

[Robert Sesek, 2014/01/14 23:18:37]

That's what I thought, just wanted to make sure.

+                          xRadius:3.5
+                          yRadius:3.5];
     [path setLineWidth:0];
     [[NSColor redColor] setStroke];
     [path stroke];
   }
 }
 
 - (NSString*)fieldValue {
   if (![self selectedItem])
     return defaultValue_;
   return [self titleOfSelectedItem];
 }
 
 - (void)setFieldValue:(NSString*)fieldValue {
   [self selectItemWithTitle:fieldValue];
   if (![self selectedItem])
     [self selectItemWithTitle:defaultValue_];
   if (![self selectedItem])
     [self selectItemAtIndex:0];
 }
 
 @end