Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 138943002: [rAC, OSX] Adjust red outline for NSPopUpButtons (Closed)

Created:
6 years, 11 months ago by groby-ooo-7-16
Modified:
6 years, 11 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, benquan, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

[rAC, OSX] Adjust red outline for NSPopUpButtons Made red outline match NSPopUpButton pixel for pixel. R=rsesek@chromium.org BUG=325492 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245465

Patch Set 1 #

Total comments: 5

Patch Set 2 : Review fixes #

Patch Set 3 : Special-casing around NSIntegralRect's 0-width special case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm View 1 1 chunk +4 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/autofill_section_container.mm View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/autofill/simple_grid_layout.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/autofill/simple_grid_layout_unittest.mm View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
groby-ooo-7-16
PTAL - a small update to the red outline, to ensure a pixel-perfect match
6 years, 11 months ago (2014-01-14 22:50:50 UTC) #1
Robert Sesek
https://codereview.chromium.org/138943002/diff/1/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm File chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm (right): https://codereview.chromium.org/138943002/diff/1/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm#newcode94 chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm:94: NSInsetRect(frame, 3.0, 3.5), -.5, -1.0) nit: join with previous ...
6 years, 11 months ago (2014-01-14 22:52:16 UTC) #2
groby-ooo-7-16
https://codereview.chromium.org/138943002/diff/1/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm File chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm (right): https://codereview.chromium.org/138943002/diff/1/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm#newcode94 chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm:94: NSInsetRect(frame, 3.0, 3.5), -.5, -1.0) On 2014/01/14 22:52:17, rsesek ...
6 years, 11 months ago (2014-01-14 23:14:55 UTC) #3
Robert Sesek
lgtm https://codereview.chromium.org/138943002/diff/1/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm File chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm (right): https://codereview.chromium.org/138943002/diff/1/chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm#newcode94 chrome/browser/ui/cocoa/autofill/autofill_pop_up_button.mm:94: NSInsetRect(frame, 3.0, 3.5), -.5, -1.0) On 2014/01/14 23:14:55, ...
6 years, 11 months ago (2014-01-14 23:18:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/138943002/60001
6 years, 11 months ago (2014-01-15 05:29:02 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=211947
6 years, 11 months ago (2014-01-15 16:25:09 UTC) #6
groby-ooo-7-16
Heads-up: Fixed unit tests, since NSIntegralRect treats 0-height rectangles as "special" and collapses them to ...
6 years, 11 months ago (2014-01-15 21:12:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/138943002/370001
6 years, 11 months ago (2014-01-17 00:10:48 UTC) #8
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 07:24:04 UTC) #9
Message was sent while issue was closed.
Change committed as 245465

Powered by Google App Engine
This is Rietveld 408576698