WIP: Introduce CompressibleString

third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

Index: third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
index 306d636b949661b5bec92ae512876d50336d40cd..353c5dc798719c2895b8301d114a92435ba2918b 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp
@@ -14,6 +14,11 @@ ScriptSourceCode::ScriptSourceCode()
 }
 
 ScriptSourceCode::ScriptSourceCode(const String& source, const KURL& url, const TextPosition& startPosition)
+    : ScriptSourceCode(CompressableString::create(source), url, startPosition)

[haraken, 2015/10/22 16:03:31]

I'm wondering why you need to create a new CompressableString here.
ScriptResource::script() returns a CompressableString*, so you just need to
catch it by ScriptSourceCode::m_source (which is RefPtr<CompressableString>).

[hajimehoshi, 2015/10/26 09:34:02]

This is backward compatibility. For example, XMLDocumentParser uses this
constructor. I can remove this and fix callers instead.

+{
+}
+
+ScriptSourceCode::ScriptSourceCode(PassRefPtrWillBeRawPtr<CompressableString> source, const KURL& url, const TextPosition& startPosition)
     : m_source(source)
     , m_resource(0)
     , m_url(url)
@@ -76,14 +81,14 @@ String ScriptSourceCode::sourceMapUrl() const
 void ScriptSourceCode::treatNullSourceAsEmpty()
 {
     // ScriptSourceCode allows for the representation of the null/not-there-really ScriptSourceCode value.
-    // Encoded by way of a m_source.isNull() being true, with the nullary constructor to be used to
+    // Encoded by way of a m_source->isNull() being true, with the nullary constructor to be used to
     // construct such a value.
     //
     // Should the other constructors be passed a null string, that is interpreted as representing
     // the empty script. Consequently, we need to disambiguate between such null string occurrences.
     // Do that by converting the latter case's null strings into empty ones.
-    if (m_source.isNull())
-        m_source = "";
+    if (!m_source)
+        m_source = CompressableString::create("");
 }
 
 } // namespace blink