WIP: Introduce CompressibleString

third_party/WebKit/Source/bindings/core/v8/ScriptSourceCode.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "bindings/core/v8/ScriptSourceCode.h"
 
 namespace blink {
 
 ScriptSourceCode::ScriptSourceCode()
     : m_resource(0)
     , m_startPosition(TextPosition::minimumPosition())
 {
 }
 
 ScriptSourceCode::ScriptSourceCode(const String& source, const KURL& url, const TextPosition& startPosition)
+    : ScriptSourceCode(CompressableString::create(source), url, startPosition)

[haraken, 2015/10/22 16:03:31]

I'm wondering why you need to create a new CompressableString here.
ScriptResource::script() returns a CompressableString*, so you just need to
catch it by ScriptSourceCode::m_source (which is RefPtr<CompressableString>).

[hajimehoshi, 2015/10/26 09:34:02]

This is backward compatibility. For example, XMLDocumentParser uses this
constructor. I can remove this and fix callers instead.

+{
+}
+
+ScriptSourceCode::ScriptSourceCode(PassRefPtrWillBeRawPtr<CompressableString> source, const KURL& url, const TextPosition& startPosition)
     : m_source(source)
     , m_resource(0)
     , m_url(url)
     , m_startPosition(startPosition)
 {
     treatNullSourceAsEmpty();
     if (!m_url.isEmpty())
         m_url.removeFragmentIdentifier();
 }
 
@@ skipping 42 matching lines @@
     if (sourceMapUrl.isEmpty()) {
         // Try to get deprecated header.
         sourceMapUrl = response.httpHeaderField("X-SourceMap");
     }
     return sourceMapUrl;
 }
 
 void ScriptSourceCode::treatNullSourceAsEmpty()
 {
     // ScriptSourceCode allows for the representation of the null/not-there-really ScriptSourceCode value.
-    // Encoded by way of a m_source.isNull() being true, with the nullary constructor to be used to
+    // Encoded by way of a m_source->isNull() being true, with the nullary constructor to be used to
     // construct such a value.
     //
     // Should the other constructors be passed a null string, that is interpreted as representing
     // the empty script. Consequently, we need to disambiguate between such null string occurrences.
     // Do that by converting the latter case's null strings into empty ones.
-    if (m_source.isNull())
-        m_source = "";
+    if (!m_source)
+        m_source = CompressableString::create("");
 }
 
 } // namespace blink