Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: test/unittests/compiler/register-allocator-unittest.cc

Issue 1389373002: [turbofan] Create ExplicitOperands to specify operands without virtual registers (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Tweaks Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/unittests/compiler/register-allocator-unittest.cc
diff --git a/test/unittests/compiler/register-allocator-unittest.cc b/test/unittests/compiler/register-allocator-unittest.cc
index c5ff90f301ec2ecc6165c57d997412b0a2adbe14..113a88873586f359ee91beae89311132128a0b20 100644
--- a/test/unittests/compiler/register-allocator-unittest.cc
+++ b/test/unittests/compiler/register-allocator-unittest.cc
@@ -41,8 +41,9 @@ bool AllocatedOperandMatches(
const AllocatedOperand& op,
const InstructionSequenceTest::TestOperand& test_op) {
return AreOperandsOfSameType(op, test_op) &&
- ((op.IsRegister() ? op.GetRegister().code() : op.index()) ==
- test_op.value_ ||
+ ((op.IsRegister()
+ ? LocationOperand::cast(op).GetRegister().code()
+ : LocationOperand::cast(op).index()) == test_op.value_ ||
test_op.value_ == InstructionSequenceTest::kNoValue);
Mircea Trofin 2015/10/15 15:05:38 Should we also have a unit test where the register
danno 2015/10/23 08:07:50 The register allocator itself should never see Exp
}

Powered by Google App Engine
This is Rietveld 408576698