[turbofan] Create ExplicitOperands to specify operands without virtual registers

test/unittests/compiler/register-allocator-unittest.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/pipeline.h"
 #include "test/unittests/compiler/instruction-sequence-unittest.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
@@ skipping 23 matching lines @@
 
   return (op.IsRegister() && test_op_is_reg) ||
          (op.IsStackSlot() && !test_op_is_reg);
 }
 
 
 bool AllocatedOperandMatches(
     const AllocatedOperand& op,
     const InstructionSequenceTest::TestOperand& test_op) {
   return AreOperandsOfSameType(op, test_op) &&
-         ((op.IsRegister() ? op.GetRegister().code() : op.index()) ==
-              test_op.value_ ||
+         ((op.IsRegister()
+               ? LocationOperand::cast(op).GetRegister().code()
+               : LocationOperand::cast(op).index()) == test_op.value_ ||
           test_op.value_ == InstructionSequenceTest::kNoValue);

[Mircea Trofin, 2015/10/15 15:05:38]

Should we also have a unit test where the register allocator encounters an
ExplicitOperand?

[danno, 2015/10/23 08:07:50]

The register allocator itself should never see ExplicitOperands, if it does it
will DCHECK fail when converting the ExplicitOperand to an AllocatedOperand.
I've changed this test to not use LocationOperand so that it's clear that only
AllocatedOperands are involved.

 }
 
 
 int GetParallelMoveCount(int instr_index, Instruction::GapPosition gap_pos,
                          const InstructionSequence* sequence) {
   const ParallelMove* moves =
       sequence->InstructionAt(instr_index)->GetParallelMove(gap_pos);
   if (moves == nullptr) return 0;
   return GetMoveCount(*moves);
 }
@@ skipping 721 matching lines @@
 INSTANTIATE_TEST_CASE_P(
     RegisterAllocatorTest, SlotConstraintTest,
     ::testing::Combine(::testing::ValuesIn(kParameterTypes),
                        ::testing::Range(0, SlotConstraintTest::kMaxVariant)));
 
 #endif  // GTEST_HAS_COMBINE
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8