Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1389353004: Remove isolate argument from handle allocation: Part II (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove isolate argument from handle allocation: Part II BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/8d618766a88db98a41bbcd53c297974a4d7e6533

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : c #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -217 lines) Patch
M runtime/vm/flow_graph_builder.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/json_stream.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M runtime/vm/message.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/vm/native_api_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/native_entry.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/vm/object.cc View 1 2 69 chunks +193 lines, -163 lines 0 comments Download
M runtime/vm/object_store.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M runtime/vm/parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/profiler_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/report.cc View 1 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/report_test.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/snapshot.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/snapshot.cc View 6 chunks +9 lines, -9 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/vm/stub_code.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/symbols.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/tags.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 2 months ago (2015-10-12 20:32:20 UTC) #2
regis
lgtm https://codereview.chromium.org/1389353004/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1389353004/diff/20001/runtime/vm/object.cc#newcode3889 runtime/vm/object.cc:3889: thsi.LookupDynamicFunction(Symbols::Call())); Should fit on one line now.
5 years, 2 months ago (2015-10-12 20:48:30 UTC) #3
srdjan
https://codereview.chromium.org/1389353004/diff/20001/runtime/vm/object.cc File runtime/vm/object.cc (right): https://codereview.chromium.org/1389353004/diff/20001/runtime/vm/object.cc#newcode3889 runtime/vm/object.cc:3889: thsi.LookupDynamicFunction(Symbols::Call())); On 2015/10/12 20:48:30, regis wrote: > Should fit ...
5 years, 2 months ago (2015-10-12 20:56:51 UTC) #4
srdjan
5 years, 2 months ago (2015-10-12 21:07:02 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
8d618766a88db98a41bbcd53c297974a4d7e6533 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698