Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: runtime/vm/report.cc

Issue 1389353004: Remove isolate argument from handle allocation: Part II (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: c Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/profiler_service.cc ('k') | runtime/vm/report_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/report.cc
diff --git a/runtime/vm/report.cc b/runtime/vm/report.cc
index f1cf49508a1c40c470a1a9de33a5cb8beef74354..e65391d5a528053b0e28f2f9c40a203ff3a58711 100644
--- a/runtime/vm/report.cc
+++ b/runtime/vm/report.cc
@@ -224,14 +224,14 @@ void Report::JSWarningFromFrame(StackFrame* caller_frame, const char* msg) {
ASSERT(caller_frame != NULL);
ASSERT(FLAG_warn_on_javascript_compatibility);
if (FLAG_silent_warnings) return;
- Isolate* isolate = Isolate::Current();
- const Code& caller_code = Code::Handle(isolate,
+ Zone* zone = Thread::Current()->zone();
+ const Code& caller_code = Code::Handle(zone,
caller_frame->LookupDartCode());
ASSERT(!caller_code.IsNull());
const uword caller_pc = caller_frame->pc();
const intptr_t token_pos = caller_code.GetTokenIndexOfPC(caller_pc);
- const Function& caller = Function::Handle(isolate, caller_code.function());
- const Script& script = Script::Handle(isolate, caller.script());
+ const Function& caller = Function::Handle(zone, caller_code.function());
+ const Script& script = Script::Handle(zone, caller.script());
MessageF(kJSWarning, script, token_pos, "%s", msg);
}
« no previous file with comments | « runtime/vm/profiler_service.cc ('k') | runtime/vm/report_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698