Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(752)

Issue 13893004: Revert 194184 "push MouseMove through WebContents and back to de..." (Closed)

Created:
7 years, 8 months ago by scottmg
Modified:
7 years, 8 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 194184 "push MouseMove through WebContents and back to de..." Broke mouse dodge on Mac, and perhaps isn't correct for Win Aura anyhow. BUG=233299 > push MouseMove through WebContents and back to delegate to fix status bubble avoid > > This fixes the status bubble not "dodging" the mouse on Aura. > > On non-Aura, the path to get to StatusBubbleViews::MouseMoved is: > - RenderWidgetHostViewWin::OnMouseEvent > - SendMessage to the parent window > - WebContentsViewWin::OnMouseMove > - Browser::ContentsMouseEvent > - StatusBubbleViews::MouseMoved > > On Aura, the path is: > - HWNDMessageHandler > - DesktkopRootWindowHostWin::HandleMouseEvent > - RootWindow::OnHostMoustEvent > - EventDispatcher, etc. > - content::RenderWidgetHostViewAura::OnMouseEvent > - RenderViewHostImpl::ForwardMouseEvent > - WebContentsImpl::HandleMouseMove // *** > - Browser::ContentsMoveEvent > - StatusBubbleViews::MouseMoved. > > This patch implements HandleMouseMove in WebContentsImpl to delegate back to Browser for Aura at ***. > > R=jam@chromium.org > > Review URL: https://codereview.chromium.org/14234020 TBR=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195027

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M trunk/src/content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M trunk/src/content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M trunk/src/content/public/browser/web_contents_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
7 years, 8 months ago (2013-04-19 00:29:08 UTC) #1
scottmg
7 years, 8 months ago (2013-04-19 00:29:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r195027.

Powered by Google App Engine
This is Rietveld 408576698