Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Issue 14234020: push MouseMove through WebContents and back to delegate to fix status bubble avoid (Closed)

Created:
7 years, 8 months ago by scottmg
Modified:
7 years, 8 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

push MouseMove through WebContents and back to delegate to fix status bubble avoid This fixes the status bubble not "dodging" the mouse on Aura. On non-Aura, the path to get to StatusBubbleViews::MouseMoved is: - RenderWidgetHostViewWin::OnMouseEvent - SendMessage to the parent window - WebContentsViewWin::OnMouseMove - Browser::ContentsMouseEvent - StatusBubbleViews::MouseMoved On Aura, the path is: - HWNDMessageHandler - DesktkopRootWindowHostWin::HandleMouseEvent - RootWindow::OnHostMoustEvent - EventDispatcher, etc. - content::RenderWidgetHostViewAura::OnMouseEvent - RenderViewHostImpl::ForwardMouseEvent - WebContentsImpl::HandleMouseMove // *** - Browser::ContentsMoveEvent - StatusBubbleViews::MouseMoved. This patch implements HandleMouseMove in WebContentsImpl to delegate back to Browser for Aura at ***. R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M content/browser/web_contents/web_contents_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
(lmk if ben/sky is better for this)
7 years, 8 months ago (2013-04-12 21:01:54 UTC) #1
jam
lgtm
7 years, 8 months ago (2013-04-15 15:32:09 UTC) #2
scottmg
7 years, 8 months ago (2013-04-15 16:01:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r194184 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698