fpdfsdk/src/javascript/Document.h - Issue 1389163007: Pass IJS_Runtime, not IJS_Context, to native object constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/javascript/Document.h

Issue 1389163007: Pass IJS_Runtime, not IJS_Context, to native object constructors. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Nits, no pass-by-non-const-ref Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/javascript/Document.h

diff --git a/fpdfsdk/src/javascript/Document.h b/fpdfsdk/src/javascript/Document.h

index 8f68769eb915db88a6deb9a9cbedfd9d121e3f8e..4e6fdee21892071ca33dc5958221fee277b9d50d 100644

--- a/fpdfsdk/src/javascript/Document.h

+++ b/fpdfsdk/src/javascript/Document.h

@@ -309,7 +309,7 @@ class CJS_Document : public CJS_Object {

~CJS_Document() override {}

// CJS_Object

- FX_BOOL InitInstance(IJS_Context* cc) override;

+ void InitInstance(IJS_Runtime* pIRuntime) override;

DECLARE_JS_CLASS();

« fpdfsdk/src/fsdk_actionhandler.cpp ('K') | « fpdfsdk/src/fsdk_baseform.cpp ('k') | fpdfsdk/src/javascript/Document.cpp » ('j') | no next file with comments »