fpdfsdk/src/fsdk_baseform.cpp - Issue 1389163007: Pass IJS_Runtime, not IJS_Context, to native object constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fsdk_baseform.cpp

Issue 1389163007: Pass IJS_Runtime, not IJS_Context, to native object constructors. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Nits, no pass-by-non-const-ref Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/fsdk_baseform.cpp

diff --git a/fpdfsdk/src/fsdk_baseform.cpp b/fpdfsdk/src/fsdk_baseform.cpp

index ff71c2bceedd5abb8ccabb9752fb66ef5aece5a9..b5b5b3f96f3082fb27f3c243073db3ae9110e1a3 100644

--- a/fpdfsdk/src/fsdk_baseform.cpp

+++ b/fpdfsdk/src/fsdk_baseform.cpp

@@ -1784,7 +1784,7 @@ void CPDFSDK_InterForm::OnCalculate(CPDF_FormField* pFormField) {

pContext->OnField_Calculate(pFormField, pField, sValue, bRC);

CFX_WideString sInfo;

- FX_BOOL bRet = pContext->RunScript(csJS, sInfo);

+ FX_BOOL bRet = pContext->RunScript(csJS, &sInfo);

pRuntime->ReleaseContext(pContext);

if (bRet) {

@@ -1846,7 +1846,7 @@ CFX_WideString CPDFSDK_InterForm::OnFormat(CPDF_FormField* pFormField,

pContext->OnField_Format(pFormField, Value, TRUE);

CFX_WideString sInfo;

- FX_BOOL bRet = pContext->RunScript(script, sInfo);

+ FX_BOOL bRet = pContext->RunScript(script, &sInfo);

pRuntime->ReleaseContext(pContext);

if (bRet) {

« fpdfsdk/src/fsdk_actionhandler.cpp ('K') | « fpdfsdk/src/fsdk_actionhandler.cpp ('k') | fpdfsdk/src/javascript/Document.h » ('j') | no next file with comments »