Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 138913010: A64: Make the simulator sampling friendly. (Closed)

Created:
6 years, 10 months ago by Rodolph Perfetta (ARM)
Modified:
6 years, 10 months ago
Reviewers:
m.m.capewell
CC:
v8-dev
Visibility:
Public.

Description

A64: Make the simulator sampling friendly. This commit ensure that if the simulator is interrupted while doing a load or a store, the stack will look consistent i.e. there is no data below the stack pointer. Also added stack-checks to ldp/stp. BUG= R=m.m.capewell@googlemail.com Committed: https://code.google.com/p/v8/source/detail?r=19239

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -31 lines) Patch
M src/a64/constants-a64.h View 1 chunk +7 lines, -1 line 0 comments Download
M src/a64/instructions-a64.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/a64/instructions-a64.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M src/a64/simulator-a64.h View 1 chunk +7 lines, -3 lines 0 comments Download
M src/a64/simulator-a64.cc View 6 chunks +95 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Rodolph Perfetta (ARM)
6 years, 10 months ago (2014-02-10 19:20:32 UTC) #1
m.m.capewell
lgtm
6 years, 10 months ago (2014-02-10 19:22:09 UTC) #2
Rodolph Perfetta (ARM)
6 years, 10 months ago (2014-02-10 19:23:57 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19239 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698