Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1389063002: Revert of factories should return baseclass, allowing the impl to specialize (Closed)

Created:
5 years, 2 months ago by Stephen Chennney
Modified:
5 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of factories should return baseclass, allowing the impl to specialize (patchset #4 id:60001 of https://codereview.chromium.org/1390523005/ ) Reason for revert: Breaks Chrome with this link error: ../../third_party/skia/include/effects/SkMorphologyImageFilter.h:75: error: undefined reference to 'SkMorphologyImageFilter::SkMorphologyImageFilter(int, int, SkImageFilter*, SkImageFilter::CropRect const*)' ../../third_party/skia/include/effects/SkMorphologyImageFilter.h:104: error: undefined reference to 'SkMorphologyImageFilter::SkMorphologyImageFilter(int, int, SkImageFilter*, SkImageFilter::CropRect const*)' Presumably due to code in third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp that contains: #include "SkMorphologyImageFilter.h" ... if (m_type == FEMORPHOLOGY_OPERATOR_DILATE) return adoptRef(SkDilateImageFilter::Create(radiusX, radiusY, input.get(), &rect)); return adoptRef(SkErodeImageFilter::Create(radiusX, radiusY, input.get(), &rect)); Original issue's description: > factories should return baseclass, allowing the impl to specialize > > waiting on https://codereview.chromium.org/1386163002/# to land > > BUG=skia:4424 > > Committed: https://skia.googlesource.com/skia/+/80a6dcaa1b757826ed7414f64b035d512d9ccbf8 TBR=senorblanco@google.com,robertphillips@google.com,reed@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4424 Committed: https://skia.googlesource.com/skia/+/95376a0dde3cdf414eb97a20cef3af19ed7e0151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -121 lines) Patch
M bench/MorphologyBench.cpp View 1 chunk +1 line, -1 line 0 comments Download
M gm/bigtileimagefilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/filterfastbounds.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M gm/pictureimagefilter.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 2 chunks +15 lines, -11 lines 0 comments Download
M include/effects/SkDropShadowImageFilter.h View 2 chunks +10 lines, -10 lines 0 comments Download
M include/effects/SkMergeImageFilter.h View 2 chunks +13 lines, -13 lines 0 comments Download
M include/effects/SkMorphologyImageFilter.h View 6 chunks +9 lines, -9 lines 0 comments Download
M include/effects/SkOffsetImageFilter.h View 1 chunk +8 lines, -10 lines 0 comments Download
M include/effects/SkPictureImageFilter.h View 6 chunks +9 lines, -11 lines 0 comments Download
M include/effects/SkPixelXorXfermode.h View 1 chunk +4 lines, -3 lines 0 comments Download
M include/effects/SkRectShaderImageFilter.h View 1 chunk +6 lines, -7 lines 0 comments Download
M include/effects/SkTableMaskFilter.h View 2 chunks +9 lines, -9 lines 0 comments Download
M include/effects/SkTestImageFilters.h View 2 chunks +6 lines, -6 lines 0 comments Download
M include/effects/SkTileImageFilter.h View 2 chunks +7 lines, -6 lines 0 comments Download
M src/effects/SkRectShaderImageFilter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/effects/SkTileImageFilter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/ImageFilterTest.cpp View 3 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Stephen Chennney
Created Revert of factories should return baseclass, allowing the impl to specialize
5 years, 2 months ago (2015-10-06 19:54:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1389063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1389063002/1
5 years, 2 months ago (2015-10-06 19:55:17 UTC) #2
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 2 months ago (2015-10-06 19:55:19 UTC) #3
Stephen White
On 2015/10/06 19:55:19, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 2 months ago (2015-10-06 19:59:11 UTC) #4
Stephen White
Oh wait, you did. Not sure what the CQ is talking about here, then.
5 years, 2 months ago (2015-10-06 19:59:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/95376a0dde3cdf414eb97a20cef3af19ed7e0151
5 years, 2 months ago (2015-10-06 20:00:00 UTC) #6
Stephen Chennney
5 years, 2 months ago (2015-10-06 20:07:34 UTC) #7
Message was sent while issue was closed.
The problem was the removal of SK_API on SkMorphologyImageFilter

Powered by Google App Engine
This is Rietveld 408576698