|
Revert of factories should return baseclass, allowing the impl to specialize (patchset #4 id:60001 of https://codereview.chromium.org/1390523005/ )
Reason for revert:
Breaks Chrome with this link error: ../../third_party/skia/include/effects/SkMorphologyImageFilter.h:75: error: undefined reference to 'SkMorphologyImageFilter::SkMorphologyImageFilter(int, int, SkImageFilter*, SkImageFilter::CropRect const*)'
../../third_party/skia/include/effects/SkMorphologyImageFilter.h:104: error: undefined reference to 'SkMorphologyImageFilter::SkMorphologyImageFilter(int, int, SkImageFilter*, SkImageFilter::CropRect const*)'
Presumably due to code in third_party/WebKit/Source/platform/graphics/filters/FEMorphology.cpp that contains:
#include "SkMorphologyImageFilter.h"
...
if (m_type == FEMORPHOLOGY_OPERATOR_DILATE)
return adoptRef(SkDilateImageFilter::Create(radiusX, radiusY, input.get(), &rect));
return adoptRef(SkErodeImageFilter::Create(radiusX, radiusY, input.get(), &rect));
Original issue's description:
> factories should return baseclass, allowing the impl to specialize
>
> waiting on https://codereview.chromium.org/1386163002/# to land
>
> BUG= skia:4424
>
> Committed: https://skia.googlesource.com/skia/+/80a6dcaa1b757826ed7414f64b035d512d9ccbf8
TBR=senorblanco@google.com,robertphillips@google.com,reed@google.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= skia:4424
Committed: https://skia.googlesource.com/skia/+/95376a0dde3cdf414eb97a20cef3af19ed7e0151
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+127 lines, -121 lines) |
Patch |
|
M |
bench/MorphologyBench.cpp
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
|
M |
gm/bigtileimagefilter.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
gm/filterfastbounds.cpp
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
gm/pictureimagefilter.cpp
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
|
M |
include/effects/SkBlurImageFilter.h
|
View
|
|
2 chunks |
+15 lines, -11 lines |
0 comments
|
Download
|
|
M |
include/effects/SkDropShadowImageFilter.h
|
View
|
|
2 chunks |
+10 lines, -10 lines |
0 comments
|
Download
|
|
M |
include/effects/SkMergeImageFilter.h
|
View
|
|
2 chunks |
+13 lines, -13 lines |
0 comments
|
Download
|
|
M |
include/effects/SkMorphologyImageFilter.h
|
View
|
|
6 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
include/effects/SkOffsetImageFilter.h
|
View
|
|
1 chunk |
+8 lines, -10 lines |
0 comments
|
Download
|
|
M |
include/effects/SkPictureImageFilter.h
|
View
|
|
6 chunks |
+9 lines, -11 lines |
0 comments
|
Download
|
|
M |
include/effects/SkPixelXorXfermode.h
|
View
|
|
1 chunk |
+4 lines, -3 lines |
0 comments
|
Download
|
|
M |
include/effects/SkRectShaderImageFilter.h
|
View
|
|
1 chunk |
+6 lines, -7 lines |
0 comments
|
Download
|
|
M |
include/effects/SkTableMaskFilter.h
|
View
|
|
2 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
|
M |
include/effects/SkTestImageFilters.h
|
View
|
|
2 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
|
M |
include/effects/SkTileImageFilter.h
|
View
|
|
2 chunks |
+7 lines, -6 lines |
0 comments
|
Download
|
|
M |
src/effects/SkRectShaderImageFilter.cpp
|
View
|
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
src/effects/SkTileImageFilter.cpp
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
tests/ImageFilterTest.cpp
|
View
|
|
3 chunks |
+14 lines, -9 lines |
0 comments
|
Download
|
Total messages: 7 (0 generated)
|