Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Unified Diff: include/effects/SkPixelXorXfermode.h

Issue 1389063002: Revert of factories should return baseclass, allowing the impl to specialize (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/effects/SkPictureImageFilter.h ('k') | include/effects/SkRectShaderImageFilter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/effects/SkPixelXorXfermode.h
diff --git a/include/effects/SkPixelXorXfermode.h b/include/effects/SkPixelXorXfermode.h
index f2fe47156cc10d8f91a9b96f511efbfd28633767..8b7f3388ff705c82364c30b928ecb18f1e9d8b72 100644
--- a/include/effects/SkPixelXorXfermode.h
+++ b/include/effects/SkPixelXorXfermode.h
@@ -17,18 +17,19 @@
*/
class SK_API SkPixelXorXfermode : public SkXfermode {
public:
- static SkXfermode* Create(SkColor opColor) { return new SkPixelXorXfermode(opColor); }
+ static SkPixelXorXfermode* Create(SkColor opColor) { return new SkPixelXorXfermode(opColor); }
SK_TO_STRING_OVERRIDE()
SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkPixelXorXfermode)
protected:
+ explicit SkPixelXorXfermode(SkColor opColor) : fOpColor(opColor) {}
void flatten(SkWriteBuffer&) const override;
+
+ // override from SkXfermode
SkPMColor xferColor(SkPMColor src, SkPMColor dst) const override;
private:
- explicit SkPixelXorXfermode(SkColor opColor) : fOpColor(opColor) {}
-
SkColor fOpColor;
typedef SkXfermode INHERITED;
« no previous file with comments | « include/effects/SkPictureImageFilter.h ('k') | include/effects/SkRectShaderImageFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698