fpdfsdk/include/jsapi/fxjs_v8.h - Issue 1389003003: Remove unused global argument from FXJS_CONSTRUCTOR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/jsapi/fxjs_v8.h

Issue 1389003003: Remove unused global argument from FXJS_CONSTRUCTOR. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/include/jsapi/fxjs_v8.h

diff --git a/fpdfsdk/include/jsapi/fxjs_v8.h b/fpdfsdk/include/jsapi/fxjs_v8.h

index 289a73e14a7e684aac7d6ad360f2e3e8fdbd412e..f174b21f0ab7270b6cd5075a13e16d05fea0ddf2 100644

--- a/fpdfsdk/include/jsapi/fxjs_v8.h

+++ b/fpdfsdk/include/jsapi/fxjs_v8.h

@@ -57,9 +57,7 @@ class FXJS_ArrayBufferAllocator : public v8::ArrayBuffer::Allocator {

void Free(void* data, size_t length) override;

};

-using FXJS_CONSTRUCTOR = void (*)(IFXJS_Context* cc,

- v8::Local<v8::Object> obj,

- v8::Local<v8::Object> global);

+using FXJS_CONSTRUCTOR = void (*)(IFXJS_Context* cc, v8::Local<v8::Object> obj);

using FXJS_DESTRUCTOR = void (*)(v8::Local<v8::Object> obj);

// Call before making FXJS_PrepareIsolate call.

« no previous file with comments | « no previous file | fpdfsdk/src/javascript/JS_Define.h » ('j') | no next file with comments »