Integrate VDA with WebRTC.

content/renderer/media/renderer_gpu_video_decoder_factories.h

Index: content/renderer/media/renderer_gpu_video_decoder_factories.h
diff --git a/content/renderer/media/renderer_gpu_video_decoder_factories.h b/content/renderer/media/renderer_gpu_video_decoder_factories.h
index e05dd9af9ff78f0e9f02d9d6f22efbf014637acd..1e991bc971b709101f77a40904329041c15d4db7 100644
--- a/content/renderer/media/renderer_gpu_video_decoder_factories.h
+++ b/content/renderer/media/renderer_gpu_video_decoder_factories.h
@@ -31,9 +31,8 @@ class WebGraphicsContext3DCommandBufferImpl;
 //
 // The public methods of the class can be called from any thread, and are
 // internally trampolined to the appropriate thread.  GPU/GL-related calls go to
-// the constructor-argument loop (mostly that's the compositor thread, or the
-// renderer thread if threaded compositing is disabled), and shmem-related calls
-// go to the render thread.
+// the constructor-argument loop, and shmem-related calls go to the render
+// thread.

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

I mourn the loss of the elided bits (as I've had to refer to this comment more
times than I'm comfortable saying).

WDYT of adding to the ctor comment something like:
|message_loop| is a thread appropriate for GL-type work; typically this is the
compositor thread, unless threaded-compositing is disabled, when it'll be the
renderer thread, or a special-purpose thread e.g. for WebRTC.

[wuchengli, 2013/06/13 10:28:07]

Done.

 class CONTENT_EXPORT RendererGpuVideoDecoderFactories
     : public media::GpuVideoDecoder::Factories {
  public:
@@ -61,11 +60,19 @@ class CONTENT_EXPORT RendererGpuVideoDecoderFactories
   virtual void Abort() OVERRIDE;
   virtual bool IsAborted() OVERRIDE;
 
+  // Makes a copy of |this|.

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

nit: s/Copy/Clone/ ?  
("copy" connotes subordinate state data, which this doesn't have; it only has
members that influence function dispatch).

[wuchengli, 2013/06/13 10:28:07]

Done.

+  virtual RendererGpuVideoDecoderFactories* Copy();

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

RGVDF is refcounted so returning a raw pointer to it is almost always a bad
move; prefer to return a scoped_refptr<RGVDF> instead.

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

Drop "virtual".

[wuchengli, 2013/06/13 10:28:07]

Done.

[wuchengli, 2013/06/13 10:28:07]

Done.

+
  protected:
   friend class base::RefCountedThreadSafe<RendererGpuVideoDecoderFactories>;
   virtual ~RendererGpuVideoDecoderFactories();
 
  private:
+  RendererGpuVideoDecoderFactories(

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

Since this is only called by Copy, which is a member function, you don't need
this; you can default-construct and set members appropriately.
(I wouldn't care, except that the signature of this overload is WAY too similar
to that of the public ctor; relying on the ordering this way seems very error
prone).

[wuchengli, 2013/06/13 10:28:07]

Done.

+      scoped_refptr<base::MessageLoopProxy> message_loop,
+      scoped_refptr<GpuChannelHost> gpu_channel_host,
+      base::WeakPtr<WebGraphicsContext3DCommandBufferImpl> context);
+
   // Helper for the constructor to acquire the ContentGLContext on the
   // compositor thread (when it is enabled).
   void AsyncGetContext(WebGraphicsContext3DCommandBufferImpl* context);