Integrate VDA with WebRTC.

content/renderer/media/renderer_gpu_video_decoder_factories.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_RENDERER_MEDIA_RENDERER_GPU_VIDEO_DECODER_FACTORIES_H_
 #define CONTENT_RENDERER_MEDIA_RENDERER_GPU_VIDEO_DECODER_FACTORIES_H_
 
 #include <vector>
 
 #include "base/basictypes.h"
@@ skipping 13 matching lines @@
 class GpuChannelHost;
 class WebGraphicsContext3DCommandBufferImpl;
 
 // Glue code to expose functionality needed by media::GpuVideoDecoder to
 // RenderViewImpl.  This class is entirely an implementation detail of
 // RenderViewImpl and only has its own header to allow extraction of its
 // implementation from render_view_impl.cc which is already far too large.
 //
 // The public methods of the class can be called from any thread, and are
 // internally trampolined to the appropriate thread.  GPU/GL-related calls go to
-// the constructor-argument loop (mostly that's the compositor thread, or the
-// renderer thread if threaded compositing is disabled), and shmem-related calls
-// go to the render thread.
+// the constructor-argument loop, and shmem-related calls go to the render
+// thread.

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

I mourn the loss of the elided bits (as I've had to refer to this comment more
times than I'm comfortable saying).

WDYT of adding to the ctor comment something like:
|message_loop| is a thread appropriate for GL-type work; typically this is the
compositor thread, unless threaded-compositing is disabled, when it'll be the
renderer thread, or a special-purpose thread e.g. for WebRTC.

[wuchengli, 2013/06/13 10:28:07]

Done.

 class CONTENT_EXPORT RendererGpuVideoDecoderFactories
     : public media::GpuVideoDecoder::Factories {
  public:
   // Takes a ref on |gpu_channel_host| and tests |context| for loss before each
   // use.
   RendererGpuVideoDecoderFactories(
       GpuChannelHost* gpu_channel_host,
       const scoped_refptr<base::MessageLoopProxy>& message_loop,
       WebGraphicsContext3DCommandBufferImpl* wgc3dcbi);
 
   // media::GpuVideoDecoder::Factories implementation.
   virtual media::VideoDecodeAccelerator* CreateVideoDecodeAccelerator(
       media::VideoCodecProfile profile,
       media::VideoDecodeAccelerator::Client* client) OVERRIDE;
   virtual bool CreateTextures(int32 count, const gfx::Size& size,
                               std::vector<uint32>* texture_ids,
                               uint32 texture_target) OVERRIDE;
   virtual void DeleteTexture(uint32 texture_id) OVERRIDE;
   virtual void ReadPixels(uint32 texture_id,
                           uint32 texture_target,
                           const gfx::Size& size,
                           const SkBitmap& pixels) OVERRIDE;
   virtual base::SharedMemory* CreateSharedMemory(size_t size) OVERRIDE;
   virtual scoped_refptr<base::MessageLoopProxy> GetMessageLoop() OVERRIDE;
   virtual void Abort() OVERRIDE;
   virtual bool IsAborted() OVERRIDE;
 
+  // Makes a copy of |this|.

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

nit: s/Copy/Clone/ ?  
("copy" connotes subordinate state data, which this doesn't have; it only has
members that influence function dispatch).

[wuchengli, 2013/06/13 10:28:07]

Done.

+  virtual RendererGpuVideoDecoderFactories* Copy();

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

RGVDF is refcounted so returning a raw pointer to it is almost always a bad
move; prefer to return a scoped_refptr<RGVDF> instead.

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

Drop "virtual".

[wuchengli, 2013/06/13 10:28:07]

Done.

[wuchengli, 2013/06/13 10:28:07]

Done.

+
  protected:
   friend class base::RefCountedThreadSafe<RendererGpuVideoDecoderFactories>;
   virtual ~RendererGpuVideoDecoderFactories();
 
  private:
+  RendererGpuVideoDecoderFactories(

[Ami GONE FROM CHROMIUM, 2013/06/11 23:48:05]

Since this is only called by Copy, which is a member function, you don't need
this; you can default-construct and set members appropriately.
(I wouldn't care, except that the signature of this overload is WAY too similar
to that of the public ctor; relying on the ordering this way seems very error
prone).

[wuchengli, 2013/06/13 10:28:07]

Done.

+      scoped_refptr<base::MessageLoopProxy> message_loop,
+      scoped_refptr<GpuChannelHost> gpu_channel_host,
+      base::WeakPtr<WebGraphicsContext3DCommandBufferImpl> context);
+
   // Helper for the constructor to acquire the ContentGLContext on the
   // compositor thread (when it is enabled).
   void AsyncGetContext(WebGraphicsContext3DCommandBufferImpl* context);
 
   // Async versions of the public methods.  They use output parameters instead
   // of return values and each takes a WaitableEvent* param to signal completion
   // (except for DeleteTexture, which is fire-and-forget).
   // AsyncCreateSharedMemory runs on the renderer thread and the rest run on
   // |message_loop_|.
   // The AsyncCreateVideoDecodeAccelerator returns its output in the vda_
@@ skipping 37 matching lines @@
 
   // Textures returned by the CreateTexture() function.
   std::vector<uint32> created_textures_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(RendererGpuVideoDecoderFactories);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_RENDERER_MEDIA_RENDERER_GPU_VIDEO_DECODER_FACTORIES_H_