Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1388973002: Use #if TARGET_OS_IOS instead of #ifdef TARGET_OS_IOS. (Closed)

Created:
5 years, 2 months ago by Bill Hesse
Modified:
5 years, 2 months ago
Reviewers:
butlermatt, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use #if TARGET_OS_IOS instead of #ifdef TARGET_OS_IOS. New versions of the OS X SDK always define TARGET_OS_IOS, as 0 or 1. BUG=https://github.com/dart-lang/sdk/issues/24501 BUG=https://github.com/dart-lang/sdk/issues/24453 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/e6b85bb28cb08204f9af4a50b9da45e56159d955

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Address comment, rebase. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M runtime/bin/file_system_watcher_macos.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/platform_macos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/process_macos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/platform/globals.h View 2 chunks +4 lines, -4 lines 2 comments Download
M runtime/vm/os_macos.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Bill Hesse
I'm not sure if this is how you want to solve this. Undefined macros evaluate ...
5 years, 2 months ago (2015-10-06 14:19:12 UTC) #3
Bill Hesse
On 2015/10/06 14:19:12, Bill Hesse wrote: > I'm not sure if this is how you ...
5 years, 2 months ago (2015-10-06 14:22:18 UTC) #4
butlermatt
I know I'm not the reviewer for this, but noticed a small issue. https://codereview.chromium.org/1388973002/diff/20001/runtime/bin/file_system_watcher_macos.cc File ...
5 years, 2 months ago (2015-10-08 13:31:02 UTC) #6
Bill Hesse
https://codereview.chromium.org/1388973002/diff/20001/runtime/bin/file_system_watcher_macos.cc File runtime/bin/file_system_watcher_macos.cc (right): https://codereview.chromium.org/1388973002/diff/20001/runtime/bin/file_system_watcher_macos.cc#newcode10 runtime/bin/file_system_watcher_macos.cc:10: #if TARGET_OS_IOS On 2015/10/08 13:31:02, butlermatt wrote: > #if ...
5 years, 2 months ago (2015-10-08 14:48:47 UTC) #7
Ivan Posva
LGTM -ip https://codereview.chromium.org/1388973002/diff/40001/runtime/platform/globals.h File runtime/platform/globals.h (right): https://codereview.chromium.org/1388973002/diff/40001/runtime/platform/globals.h#newcode98 runtime/platform/globals.h:98: #define TARGET_OS_IOS 1 Should we check whether ...
5 years, 2 months ago (2015-10-12 09:23:56 UTC) #8
Bill Hesse
Committed patchset #2 (id:40001) manually as e6b85bb28cb08204f9af4a50b9da45e56159d955 (presubmit successful).
5 years, 2 months ago (2015-10-12 10:38:16 UTC) #9
Bill Hesse
5 years, 2 months ago (2015-10-12 10:38:49 UTC) #10
Message was sent while issue was closed. 
https://codereview.chromium.org/1388973002/diff/40001/runtime/platform/globals.h
File runtime/platform/globals.h (right):

https://codereview.chromium.org/1388973002/diff/40001/runtime/platform/global...
runtime/platform/globals.h:98: #define TARGET_OS_IOS 1
On 2015/10/12 09:23:56, Ivan Posva wrote:
> Should we check whether TARGET_OS_IOS has been defined before blindly
overriding
> it here?

I'm not sure what we want to do if it is defined as 0, or even why this is
necessary.  Adding a guard so it gets defined only if it was previously
undefined.

Powered by Google App Engine
This is Rietveld 408576698