runtime/platform/globals.h - Issue 1388973002: Use #if TARGET_OS_IOS instead of #ifdef TARGET_OS_IOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/platform/globals.h

Issue 1388973002: Use #if TARGET_OS_IOS instead of #ifdef TARGET_OS_IOS. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comment, rebase. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/platform/globals.h

diff --git a/runtime/platform/globals.h b/runtime/platform/globals.h

index 0d493100639328a25337fa200339be9289fefad9..db73d62365750ac733b4c1e4604747a5ceaaa669 100644

--- a/runtime/platform/globals.h

+++ b/runtime/platform/globals.h

@@ -95,7 +95,7 @@

// the value defined in TargetConditionals.h

#define TARGET_OS_MACOS 1

#if TARGET_OS_IPHONE

-#define TARGET_OS_IOS

+#define TARGET_OS_IOS 1

Ivan Posva 2015/10/12 09:23:56 Should we check whether TARGET_OS_IOS has been def

Bill Hesse 2015/10/12 10:38:48 I'm not sure what we want to do if it is defined a

#endif

#elif defined(_WIN32)

@@ -279,17 +279,17 @@ typedef simd128_value_t fpu_register_t;

#elif defined(TARGET_ARCH_X64)

// No simulator used.

#elif defined(TARGET_ARCH_ARM)

-#if !defined(HOST_ARCH_ARM) || defined(TARGET_OS_IOS)

+#if !defined(HOST_ARCH_ARM) || TARGET_OS_IOS

#define USING_SIMULATOR 1

#endif

#elif defined(TARGET_ARCH_ARM64)

-#if !defined(HOST_ARCH_ARM64) || defined(TARGET_OS_IOS)

+#if !defined(HOST_ARCH_ARM64) || TARGET_OS_IOS

#define USING_SIMULATOR 1

#endif

#elif defined(TARGET_ARCH_MIPS)

-#if !defined(HOST_ARCH_MIPS) || defined(TARGET_OS_IOS)

+#if !defined(HOST_ARCH_MIPS) || TARGET_OS_IOS

#define USING_SIMULATOR 1

#endif

« no previous file with comments | « runtime/bin/process_macos.cc ('k') | runtime/vm/os_macos.cc » ('j') | no next file with comments »